Adding a test for when peers are late#1153
Merged
lasarojc merged 5 commits intohvanz/mempool-interfacefrom Jul 24, 2023
Merged
Conversation
3 tasks
hvanz
approved these changes
Jul 24, 2023
Collaborator
hvanz
left a comment
There was a problem hiding this comment.
Good catch! Please check that the last line entry = nil is in the right posiiton.
I think now the test TestReactorTxSendersMultiNode could be improved by testing that the transactions were received in order, but we could fix it on the main PR branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some extra testing to the base one.