feat: make handshake cancelable (backport #857)#1011
Merged
sergio-mena merged 1 commit intocometbft:v0.38.xfrom Jun 22, 2023
Merged
feat: make handshake cancelable (backport #857)#1011sergio-mena merged 1 commit intocometbft:v0.38.xfrom
sergio-mena merged 1 commit intocometbft:v0.38.xfrom
Conversation
it'll make the handshake work with graceful shutdown(see: cosmos/cosmos-sdk#16202) handshake could be a long running process if there are many local blocks to replay, for example we use it to do profiling. Hope we can backport this to 0.34.x. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
3 tasks
mzabaluev
approved these changes
Jun 21, 2023
Contributor
mzabaluev
left a comment
There was a problem hiding this comment.
Looks good as a backport to me.
19 tasks
sergio-mena
approved these changes
Jun 21, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
We might need to refactor this in a breaking way (to simplify) in a future release. But this is good for a backport
Contributor
Author
the breaking version is already in main branch, is that what you mean? |
Collaborator
Oh yes, I had missed that. All good |
Contributor
|
thank you!! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it'll make the handshake work with graceful shutdown(see: cosmos/cosmos-sdk#16202)
handshake could be a long running process if there are many local blocks to replay, for example we use it to do profiling.
this one can be backport to 0.37 and 0.34.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsPR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments