-
Notifications
You must be signed in to change notification settings - Fork 782
(store/pruning): Pruner does not prune commits with vote extensions #5275
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingneeds-triageThis issue/PR has not yet been triaged by the team.This issue/PR has not yet been triaged by the team.
Description
Bug Report
Setup
CometBFT version
v0.38.x
v1.x
main
Have you tried the latest version:
yes
What happened?
The PruneBlocks function deletes block information by appending the prefix corresponding to a particular the of data :
"BP" - Block Parts
"C" - Commit
"BH" - BlockHash
etc.
When vote extensions were introduced, a new key type was introduced as well: "EC"
However, within PruneBlocks we are never calling delete on any key prefixed with "EC". See here for where the Commits are deleted. There is no corresponding line to this for extended commits containing vote extensions.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingneeds-triageThis issue/PR has not yet been triaged by the team.This issue/PR has not yet been triaged by the team.