Skip to content

e2e: bultin nodes have an empty commit hash #430

@sergio-mena

Description

@sergio-mena

Bug Report

Setup

CometBFT version (use cometbft version or git rev-parse --verify HEAD if installed from source):

main (also present in release branches)

Have you tried the latest version: yes/no
yes

ABCI app (name for built-in, URL for self-written if it's publicly available):

built-in only

Environment:

  • OS (e.g. from /etc/os-release): macOS Monterrey
  • Install tools: all via Homebrew + Docker desktop

node command runtime flags:

as prescribed by e2e logic

Config

Not relevant

What happened?

When e2e tests are run, if the nodes are configured built-in, they get an empty commit hash.

What did you expect to happen?

The hash should be present

How to reproduce it

Any e2e manifest with builtin ABCI

Logs

I[2023-03-01|14:11:26.614] Version info                                 module=main tendermint_version=0.38.0-dev abci=1.0.0 block=11 p2p=8 commit_hash=

dump_consensus_state output

N/A

Anything else we need to know

Root-caused the problem: the e2e Makefile lacks the necessary flags. PR coming up shortly.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions