Skip to content

Make late votes not enter consensus peer msg queue #3154

@ValarDragon

Description

@ValarDragon

Feature Request

Summary

Related to #2927. We should make the consensus reactor, upon seeing a vote message, check if the vote is late and ignore it, outside of consensus state's processing.

This will Save WAL writes, and time under consensus mutex

Problem Definition

On Osmosis RPC nodes, we see 2 million late votes per hour, which I think should mean considerably more work load under the consensus mutex.

Proposal

Add logic right here (https://github.com/cometbft/cometbft/blob/main/internal/consensus/reactor.go#L360-L361 ) of the form:

if vote.Height < height {
// add to late vote metrics
  return
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions