The dependency to this library was introduced by #2765.

It is present on main and v1.x branches (which is still unreleased).

We should at the moment stick to the standard crypto/sha256 library, with the same purpose.

The adoption of minio/sha256-simd was proposed in #2909, but at the moment we are not planning to switch to this non-standard library, as summarized in the following comment:

We discussed about this in our internal meeting today. These are the conclusions:

1. We currently don't have performance data that shows an obvious gain in the production setups where CometBFT is used
2. We could gather such performance data ourselves as a due-diligence activity, but we don't have cycles ATM
3. There is an ongoing longer term solution, described in docs(ADR): #113 Modular transaction hashing #2241, whereby an app can have CometBFT use custom hashing logic.
   • This longer term solution will render our efforts in point 2 unnecessary

Therefore, we will:

• Use this issue to move all imports of minio/sha256-simd (BLS-related code) to crypto/sha256
• Wait for docs(ADR): #113 Modular transaction hashing #2241 to be completed so that users can do what is suggested in this issue on app-side code

Originally posted by @sergio-mena in #2909 (comment)