Skip to content

v0.34.8: possible regression in ConsensusParams#ValidateUpdate #2109

@melekes

Description

@melekes

Bug Report

Setup

CometBFT version (use cometbft version or git rev-parse --verify HEAD if installed from source): v0.38.4

Have you tried the latest version: no

ABCI app (name for built-in, URL for self-written if it's publicly available): berachain

Environment:

  • OS (e.g. from /etc/os-release):
  • Install tools:
  • Others:

node command runtime flags:

Config

What happened?

6:42PM ERR failed to unmarshal commit info err="proto: wrong wireType = 2 for field Round" module=server
6:42PM ERR failed to process proposal err="proto: wrong wireType = 2 for field Round" hash=2819B22226DB5BC1FC70D173E81F6CEB9B8AD2FA17BCA78608CA0F97CBBE30A0 height=237778 module=server
6:42PM ERR prevote step: state machine rejected a proposed block; this should not happen:the proposer may be misbehaving; prevoting nil err=null height=237778 module=consensus round=63

4:45PM ERR failure when running app err="error during handshake: error on replay: commit failed for application: updating consensus params: vote extensions cannot be updated to a past or current height, enable height: 2, current height 216184"

What did you expect to happen?

successful replay

How to reproduce it

Logs

dump_consensus_state output

Anything else we need to know

d766d20c0

params.ABCI.VoteExtensionsEnableHeight == updated.Abci.VoteExtensionsEnableHeight

I think this is the offending change
which is not present in v0.38.4
before v0.38.4, after upgrade && during replay ApplyBlock would succeed because params.ABCI.VoteExtensionsEnableHeight == updated.Abci.VoteExtensionsEnableHeight 2 == 2 passes ✅

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions