Bug Report

TestByzantinePrevoteEquivocation is flaky

Setup

CI

Config

CI

What happened?

Sometimes TestByzantinePrevoteEquivocation works. Sometimes TestByzantinePrevoteEquivocation does not work.

In flaky test cases we don't know if it is the code or the test, by the way. This means that ByzantinePrevoteEquivocation could be malfunctioning.

What did you expect to happen?

I expect tests to work consistently.

How to reproduce it

Work on Comet

Logs

Fail Log

• https://github.com/cometbft/cometbft/actions/runs/7379656614/job/20076181734?pr=1907

Looking at the surrounding commits in:

#1907 it is quite clear no relevant changes were made.

Magic Success 1 commit later with no relevant code changes:

• https://github.com/cometbft/cometbft/actions/runs/7379829117/job/20076535412?pr=1907

Anything else we need to know

While we call these flaky tests, the name doesn't do reality justice. They're ambiguity as to weather or not one function or another actually works as designed, and they greatly slow development on comet, while making it more expensive.