Bug Report

TestListenerTimeoutReadWrite is flaky

Setup

I just used CI

Config

CI

What happened?

With no code changes other than a godoc, TestListenerTimeoutReadWrite decided to fail

What did you expect to happen?

I expected no tests to fail other than those that failed in the previous commit

How to reproduce it

Just work on comet

logs

• 9f5f93c

Another one:

• https://github.com/cometbft/cometbft/actions/runs/7379907607/job/20076706226

But then I added a godoc, and another test failed!

TestListenerTimeoutReadWrite

There were no code changes other than the godoc. Godoc should not affect test success or failure. The situation with flaky tests is robbing us of a source of truth for comet.

Anything else we need to know

Making CI reliable provides a source of truth as to the state of the code and eliminates "works on my machine" problems. If we wish to improve the reliability of comet, we need to determine why these tests are flaky, and fix it.