-
Notifications
You must be signed in to change notification settings - Fork 780
Open
Labels
Description
Summary
TestMempoolConfig sets the size of the mempool to 5000 and the size of the cache to 1000 for all the tests that use the mempool. Although it is allowed to have a cache with smaller capacity than the mempool, these values do not correspond to the normal usage, that is, a cache size (much) bigger than the mempool size.
Proposal
The main testing scenarios should target a mempool whose size is smaller or equal than the cache. This change will surely break a few tests.
We should also test the opposite scenario (that its, cache_size > mempool's size) because currently it is a valid configuration, but most probably it's not used at all, and it may be disallowed in the future.
Reactions are currently unavailable