add test and fix a test

vladjdk · vladjdk · commit dcf7e3b4bced · 2026-01-12T23:35:09.000-05:00
added test for median time and fixed the invalid signatures check, which now fails before the block is validated via the median time calculation
diff --git a/state/state_test.go b/state/state_test.go
@@ -7,6 +7,7 @@ import (
 	"math/big"
 	"os"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -1124,3 +1125,86 @@ func TestStateProto(t *testing.T) {
 		}
 	}
 }
+
+func TestMedianTime(t *testing.T) {
+	val1 := types.NewValidator(ed25519.GenPrivKey().PubKey(), 30)
+	val2 := types.NewValidator(ed25519.GenPrivKey().PubKey(), 30)
+	val3 := types.NewValidator(ed25519.GenPrivKey().PubKey(), 30)
+
+	vals := types.NewValidatorSet([]*types.Validator{val1, val2, val3})
+
+	t.Run("all validators present", func(t *testing.T) {
+		now := time.Now()
+		commit := &types.Commit{
+			Height: 1,
+			Signatures: []types.CommitSig{
+				{
+					BlockIDFlag:      types.BlockIDFlagCommit,
+					ValidatorAddress: val1.Address,
+					Timestamp:        now,
+				},
+				{
+					BlockIDFlag:      types.BlockIDFlagCommit,
+					ValidatorAddress: val2.Address,
+					Timestamp:        now.Add(1 * time.Minute),
+				},
+				{
+					BlockIDFlag:      types.BlockIDFlagCommit,
+					ValidatorAddress: val3.Address,
+					Timestamp:        now.Add(2 * time.Minute),
+				},
+			},
+		}
+
+		medianTime, err := sm.MedianTime(commit, vals)
+		require.NoError(t, err)
+		require.False(t, medianTime.IsZero())
+	})
+
+	t.Run("validator not in validator set", func(t *testing.T) {
+		unknownVal := ed25519.GenPrivKey().PubKey().Address()
+		now := time.Now()
+		commit := &types.Commit{
+			Height: 1,
+			Signatures: []types.CommitSig{
+				{
+					BlockIDFlag:      types.BlockIDFlagCommit,
+					ValidatorAddress: val1.Address,
+					Timestamp:        now,
+				},
+				{
+					BlockIDFlag:      types.BlockIDFlagCommit,
+					ValidatorAddress: unknownVal,
+					Timestamp:        now.Add(1 * time.Minute),
+				},
+			},
+		}
+
+		_, err := sm.MedianTime(commit, vals)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "commit validator not found in validator set")
+	})
+
+	t.Run("not all validators present", func(t *testing.T) {
+		now := time.Now()
+		commit := &types.Commit{
+			Height: 1,
+			Signatures: []types.CommitSig{
+				{
+					BlockIDFlag:      types.BlockIDFlagCommit,
+					ValidatorAddress: val1.Address,
+					Timestamp:        now,
+				},
+				{
+					BlockIDFlag:      types.BlockIDFlagCommit,
+					ValidatorAddress: val2.Address,
+					Timestamp:        now.Add(1 * time.Minute),
+				},
+			},
+		}
+
+		medianTime, err := sm.MedianTime(commit, vals)
+		require.NoError(t, err)
+		require.False(t, medianTime.IsZero())
+	})
+}
diff --git a/state/validation_test.go b/state/validation_test.go
@@ -196,14 +196,8 @@ func TestValidateBlockCommit(t *testing.T) {
 				#2589: test len(block.LastCommit.Signatures) == state.LastValidators.Size()
 			*/
 			block, err = makeBlock(state, height, wrongSigsCommit)
-			require.NoError(t, err)
-			err = blockExec.ValidateBlock(state, block)
-			_, isErrInvalidCommitSignatures := err.(types.ErrInvalidCommitSignatures)
-			require.True(t, isErrInvalidCommitSignatures,
-				"expected ErrInvalidCommitSignatures at height %d, but got: %v",
-				height,
-				err,
-			)
+			require.Error(t, err)
+			require.ErrorContains(t, err, "error making block")
 		}
 
 		/*
