chore: relax Go version constraint to 1.23 (#4964)

Zachary Becker · web-flow · commit a8b48c7e1a56 · 2025-02-20T15:38:12.000Z
This PR relaxes to Go version from 1.23 from 1.23.5. This should implicitly use the latest patch version by default, but let dependent modules control of the patch model. Although it's recommended that the latest patch is used in general. This avoids the need to constantly update this value on every Go patch upgrade. Similar change done in cometbft-db here (cometbft/cometbft-db#245) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
diff --git a/.github/workflows/go-version.env b/.github/workflows/go-version.env
@@ -1,2 +1,2 @@
 # .github/workflows/go-version.env
-GO_VERSION=1.23.5
+GO_VERSION=1.23
diff --git a/DOCKER/Dockerfile b/DOCKER/Dockerfile
@@ -1,6 +1,6 @@
 # Use a build arg to ensure that both stages use the same,
 # hopefully current, go version.
-ARG GOLANG_BASE_IMAGE=golang:1.23.5-alpine
+ARG GOLANG_BASE_IMAGE=golang:1.23-alpine
 
 # stage 1 Generate CometBFT Binary
 FROM --platform=$BUILDPLATFORM $GOLANG_BASE_IMAGE AS builder
diff --git a/README.md b/README.md
@@ -75,7 +75,7 @@ Please see [SECURITY.md](./SECURITY.md).
 
 | CometBFT version | Requirement | Version        | Tested with  |
 |------------------|-------------|----------------|--------------|
-| main             | Go version  | 1.23 or higher | up to 1.23.5 |
+| main             | Go version  | 1.23 or higher | up to 1.23.6 |
 | v1.x             | Go version  | 1.23 or higher | up to 1.23.1 |
 | v0.38.x          | Go version  | 1.22 or higher | up to 1.22   |
 
diff --git a/api/go.mod b/api/go.mod
@@ -1,6 +1,6 @@
 module github.com/cometbft/cometbft/api
 
-go 1.23.5
+go 1.23
 
 require (
 	github.com/cosmos/gogoproto v1.4.12
diff --git a/docs/tutorials/go-built-in.md b/docs/tutorials/go-built-in.md
@@ -48,7 +48,7 @@ have installed and the computer platform):
 
 ```bash
 $ go version
-go version go1.23.5 darwin/amd64
+go version go1.23.6 darwin/amd64
 
 ```
 
@@ -119,10 +119,9 @@ This should an output similar to this.
 ```bash
 go: creating new go.mod: module kvstore
 go: to add module requirements and sums:
-	go mod tidy
+go mod tidy
 ```
 
-go 1.23.5
 Now, lets add `cometbft` as a dependency to our project. Run the `go get` command below:
 
 ```bash
@@ -143,7 +142,7 @@ The go.mod file should look similar to:
 ```go
 module kvstore
 
-go 1.23.5
+go 1.23
 
 require github.com/cometbft/cometbft v1.0.0 // indirect
 ```
diff --git a/docs/tutorials/go.md b/docs/tutorials/go.md
@@ -46,7 +46,7 @@ Verify that you have the latest version of Go installed (refer to the [official
 
 ```bash
 $ go version
-go version go1.23.5 darwin/amd64
+go version go1.23.6 darwin/amd64
 ```
 
 ## 1.1 Installing CometBFT
@@ -137,7 +137,7 @@ The go.mod file should look similar to:
 ```go
 module kvstore
 
-go 1.23.5
+go 1.23
 
 
 require github.com/cometbft/cometbft v1.0.0 // indirect
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/cometbft/cometbft
 
-go 1.23.5
+go 1.23
 
 replace github.com/cometbft/cometbft/api => ./api
 
diff --git a/go.work b/go.work
@@ -1,4 +1,4 @@
-go 1.23.5
+go 1.23
 
 use (
 	.
diff --git a/test/e2e/docker/Dockerfile b/test/e2e/docker/Dockerfile
@@ -1,5 +1,5 @@
 # We need to build in a Linux environment to support C libraries.
-FROM golang:1.23.5
+FROM golang:1.23
 
 RUN apt-get -qq update -y && apt-get -qq upgrade -y >/dev/null
 
diff --git a/test/e2e/docker/Dockerfile.debug b/test/e2e/docker/Dockerfile.debug
@@ -1,5 +1,5 @@
 # We need to build in a Linux environment to support C libraries.
-FROM golang:1.23.5
+FROM golang:1.23
 
 RUN apt-get -qq update -y && apt-get -qq upgrade -y >/dev/null
 RUN apt-get -qq install -y zsh vim >/dev/null

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`# .github/workflows/go-version.env`
`2`		`-GO_VERSION=1.23.5`
	`2`	`+GO_VERSION=1.23`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-go 1.23.5`
	`1`	`+go 1.23`
`2`	`2`
`3`	`3`	`use (`
`4`	`4`	`.`