Updating RcppArmadillo initialization#23
Merged
comeetie merged 1 commit intocomeetie:RcppUpdate011from Sep 7, 2022
Merged
Conversation
These six two-line changes update RcppArmadillo from the now deprecated `<<` initialization to brace initialization allowed since C++11 and long been the minimal standard with R too. It would be great if you could merge this, and release and updated package "in the next little while" -- see the two prior emails I sent, and the transition log at RcppCore/RcppArmadillo#391
Closed
31 tasks
Owner
|
Thanks a lot for the PR. I will merge and submit a new version to the cran before the end of the week. |
Contributor
Author
|
Sounds good, amd no rush as I think other will be slower (but hey, "done is done"). Let me know if you need help with the Matrix transition, I went through that last month for two packages (incl RcppArmadillo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These six two-line changes update RcppArmadillo from the now
deprecated
<<initialization to brace initialization allowed sinceC++11 and long been the minimal standard with R too. It would be
great if you could merge this, and release and updated package "in the
next little while" -- see the two prior emails I sent, and the
transition log at RcppCore/RcppArmadillo#391