Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows a simple
derivescall to work on Scala 3 enums.We add a new
macroRWAllmacro, thatderivesnow forwards to. This can be called once on each sealed trait or enum and will automatically generate themacroRcalls on all the sub-classes. We then add a pair ofsuperTypeReader/superTypeWriterforwarders to allow sub-classes to make use of super-class readers and writers automatically without any input from the user.Note that this approach does not work in Scala 2; while
macroRWAllcan be defined,superTypeReader/superTypeWriterseem to cause diverging implicit expansions. So for now I leave the Scala 2 experience unchanged