Make .ext on empty paths return "" rather than crashing with a NPE#87
Merged
Make .ext on empty paths return "" rather than crashing with a NPE#87
Conversation
Member
Author
|
CI failure seems like a flake |
lefou
reviewed
Dec 8, 2021
Member
lefou
left a comment
There was a problem hiding this comment.
Nice fix. I think I spotted one issue.
I also like the new lastOption idea, which is effectively a lastOpt. Definitely better than returning an empty string from .last.
os/src/Path.scala
Outdated
| } | ||
|
|
||
| def last: String | ||
| def last: String = lastOpt.getOrElse("empty path has no last segment") |
Member
There was a problem hiding this comment.
Did you mean to throw an exception here?
Member
Author
There was a problem hiding this comment.
Hah good catch. I'll add a test to cover this error behavior as well
Member
Author
|
@lefou this should be ready for another look |
Member
|
This should be released as next minor release, because of the newly introduced method in the API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes com-lihaoyi/Ammonite#1017
This is more consistent with calling
.exton non-empty paths which have no extension, since those currently return""We also introduce a new a
lastOptionmethod, as a way to get the last segment in a list without throwing. Not sure if that's the right thing to do, or whether we should make.lastreturn""(which is otherwise not a valid return value, since path segments cannot be empty).Covered with simple unit tests