Refactor Mill to use mill.api.opt API#6800
Closed
lefou wants to merge 81 commits intocom-lihaoyi:mainfrom
Closed
Conversation
Fixed merge conflicts
mill.api.opt API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #6129
A Proof-of-concept refactoring of various modules that contain configuration data potentially containing paths. This breaks the current binary compatibility to showcase how the new API could be used. It is not set in stone and can be separated or reverted or whatever is necessary to get the API additions merged.
All tasks containing configuration data that also may contain file or directory paths should use the
Optclass or the container typeOptsorOptMap.Most prominent tasks are:
javacOptions: T[Seq[String]]-->T[Opts]scalacOptions: T[Seq[String]]-->T[Opts]kotlincOptions: T[Seq[String]]-->T[Opts]forkArgs: T[Seq[String]]-->T[Opts]forkEnv: T[OptMap]-->T[OptMap]Since the JSON serialization for paths re-use the respective upickle-serializers, the root path mapping of PR #6031 may also work here (Resulting is paths like
$MILL_OUT/task/to/jar.dest/out.jar).