expose file extensions covered by a shell extension#88
Merged
dirk-thomas merged 2 commits intomasterfrom Jul 19, 2018
Merged
Conversation
This was referenced Jul 19, 2018
| """ | ||
| Get the file extensions provided by this extension. | ||
|
|
||
| By default the extension name will be returned. |
Contributor
There was a problem hiding this comment.
By default the shell name will be returned ?
Member
Author
There was a problem hiding this comment.
The name of the extension will be returned - as specified for the entry point.
Contributor
There was a problem hiding this comment.
yeah it just seem more prone to confusion to refer to the "file extension" or the "extension name" (referring to the colcon extension) that's why I suggested a different wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the file extensions for each shell extension available enables colcon/colcon-ros#29 which avoids hard coding those file extensions.