relax timing race in event_reactor test#345
Merged
dirk-thomas merged 4 commits intomasterfrom May 7, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 80.56% 79.31% -1.26%
==========================================
Files 56 56
Lines 3237 3297 +60
Branches 536 552 +16
==========================================
+ Hits 2608 2615 +7
- Misses 592 645 +53
Partials 37 37
Continue to review full report at Codecov.
|
d2ca28e to
66f3273
Compare
chapulina
approved these changes
May 6, 2020
chapulina
left a comment
There was a problem hiding this comment.
LRTM, where the R stands for reasonable. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. https://ci.appveyor.com/project/dirk-thomas/colcon-core/builds/32694401