refactor(plugin_client_stats): improve current version check#89
Merged
coincashew merged 1 commit intocoincashew:mainfrom May 4, 2025
Merged
Conversation
Owner
|
Great improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the version checking mechanism in the client-stats plugin by directly querying the installed binary instead of relying on a version file. This change makes the version checking more reliable and eliminates potential synchronization issues between the version file and the actual installed binary.
Changes
getCurrentVersion()function to directly query the binary versionTesting
Impact
This change improves reliability of the version checking system and eliminates a potential source of version mismatch errors. No breaking changes to the plugin's functionality.
Type of Change