Skip to content

refactor(plugin_client_stats): improve current version check#89

Merged
coincashew merged 1 commit intocoincashew:mainfrom
Jor-Tech:refactor/plugin_client_stats
May 4, 2025
Merged

refactor(plugin_client_stats): improve current version check#89
coincashew merged 1 commit intocoincashew:mainfrom
Jor-Tech:refactor/plugin_client_stats

Conversation

@Jor-Tech
Copy link
Copy Markdown
Contributor

@Jor-Tech Jor-Tech commented May 4, 2025

Description

This PR improves the version checking mechanism in the client-stats plugin by directly querying the installed binary instead of relying on a version file. This change makes the version checking more reliable and eliminates potential synchronization issues between the version file and the actual installed binary.

Changes

  • Added new getCurrentVersion() function to directly query the binary version
  • Removed version file storage mechanism
  • Updated upgrade function to use actual binary version
  • Improved error handling for cases where binary doesn't exist or version can't be determined

Testing

  • Verified version checking works with installed binary
  • Tested upgrade flow with different version scenarios
  • Confirmed proper handling of non-existent binary case

Impact

This change improves reliability of the version checking system and eliminates a potential source of version mismatch errors. No breaking changes to the plugin's functionality.

Type of Change

  • Enhancement (non-breaking change that adds functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@coincashew
Copy link
Copy Markdown
Owner

Great improvement.
Thanks for making EthPillar better every day! ❤️

@coincashew coincashew merged commit b225318 into coincashew:main May 4, 2025
1 check passed
@Jor-Tech Jor-Tech deleted the refactor/plugin_client_stats branch May 4, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants