manage_validator_keys.sh (1)

141-147: Validator-type menu width bump is fine, but consider extracting magic numbers

Raising the whiptail width from 88 → 90 brings a little more breathing room—looks good.
Long-term, putting these dimensions in constants (MENU_HEIGHT, MENU_WIDTH) will make future tweaks easier and avoid scattering “magic numbers” through the file.

deploy-lighthouse-reth.py (2)

740-748: Avoid hidden failures when FEE_RECIPIENT_ADDRESS is unset

_feeparameters becomes an empty string when FEE_RECIPIENT_ADDRESS is empty.
If the validator client is launched without this flag the user silently forfeits
MEV / block-tips.

Consider validating before service-file generation:

if VALIDATOR_ENABLED and not FEE_RECIPIENT_ADDRESS:
    sys.exit("ERROR: --fee_address is mandatory for validator modes")

or fail at argument parsing time (required=True when the chosen install mode
needs it).

---

689-699: Boolean comparisons can be simplified & silence Ruff E712

Throughout the installer (MEVBOOST_ENABLED == True, VALIDATOR_ENABLED == True
…), direct comparisons to True/False are verbose and trigger linter
complaints.

-if MEVBOOST_ENABLED == True:
+if MEVBOOST_ENABLED:

Applying the same simplification globally reduces noise and emphasises intent.

🧰 Tools

🪛 Ruff (0.8.2)

689-689: Avoid equality comparisons to True; use if MEVBOOST_ENABLED: for truth checks

Replace with MEVBOOST_ENABLED

(E712)

---

696-696: f-string without any placeholders

Remove extraneous f prefix

(F541)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

install-lighthouse-reth.sh (1)

126-126: Guard cd on clone fallback (previously raised)

cd ~/git/ethpillar still lacks || exit 1, so a failed clone that isn’t
“directory exists” will mask the root cause and run the rest of the pipeline in
an unknown directory.

(See earlier review-bot comment SC2164.)

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 126-126: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

deploy-lighthouse-reth.py (1)

14-35: 🛠️ Refactor suggestion

Prune unused & wildcard imports – they mask bugs and hurt startup time

Many modules are imported but never used and from … import * pollutes the
namespace, hiding undefined names (Ruff F401/F403/E…). Tighten the import
section and explicitly pull only what is needed:

-import fnmatch
-import random
-import json
-import tarfile
-import shutil
-import subprocess
-import tempfile
-import urllib.request
-import zipfile
-import random
-import sys
-import platform
-import tempfile
-import yaml
-from consolemenu import *
-from consolemenu.items import *
-import argparse
-from dotenv import load_dotenv, dotenv_values
-from config import *
+import argparse
+import json
+import os
+import platform
+import random
+import subprocess
+import sys
+import tarfile
+import tempfile
+
+from consolemenu import SelectionMenu, PromptUtils, Screen
+from consolemenu.items import FunctionItem
+from dotenv import load_dotenv
+from tqdm import tqdm
+
+# Pull only the symbols actually used from config.py
+from config import (
+    mainnet_sync_urls, holesky_sync_urls, hoodi_sync_urls,
+    sepolia_sync_urls, ephemery_sync_urls,
+    mainnet_relay_options, hoodi_relay_options,
+    holesky_relay_options, sepolia_relay_options,
+)

You’ll then need to update the few references that relied on the star-imports
(SelectionMenu, PromptUtils, etc.) – they’re already in the explicit list
above.
Benefits: faster startup, better static analysis, smaller attack surface.

🧰 Tools

🪛 Ruff (0.8.2)

17-17: fnmatch imported but unused

Remove unused import: fnmatch

(F401)

---

21-21: shutil imported but unused

Remove unused import: shutil

(F401)

---

24-24: urllib.request imported but unused

Remove unused import: urllib.request

(F401)

---

25-25: zipfile imported but unused

Remove unused import: zipfile

(F401)

---

26-26: Redefinition of unused random from line 18

Remove definition: random

(F811)

---

29-29: Redefinition of unused tempfile from line 23

Remove definition: tempfile

(F811)

---

30-30: yaml imported but unused

Remove unused import: yaml

(F401)

---

31-31: from consolemenu import * used; unable to detect undefined names

(F403)

---

32-32: from consolemenu.items import * used; unable to detect undefined names

(F403)

---

34-34: dotenv.dotenv_values imported but unused

Remove unused import: dotenv.dotenv_values

(F401)

---

35-35: from config import * used; unable to detect undefined names

(F403)

install-lighthouse-reth.sh (1)

115-120: Optional: avoid polluting ~/.local with the virtual-env

Creating a venv directly in ~/.local mixes venv artefacts with user-installed
Python packages. Consider ~/.ethpillar-venv (or similar) instead to keep the
directory clean and easy to remove.

deploy-lighthouse-reth.py (1)

353-357: Pythonic truth checks

if MEVBOOST_ENABLED == True is verbose and flagged by linters (E712). Use a
direct truthy test:

-if MEVBOOST_ENABLED == True and not VALIDATOR_ONLY:
+if MEVBOOST_ENABLED and not VALIDATOR_ONLY:

Same pattern recurs later for VALIDATOR_ENABLED, NODE_ONLY, etc.

🧰 Tools

🪛 Ruff (0.8.2)

353-353: Avoid equality comparisons to True; use if MEVBOOST_ENABLED: for truth checks

Replace with MEVBOOST_ENABLED

(E712)

install-lighthouse-reth.sh (2)

98-103: 🛠️ Refactor suggestion

Capture failures from both apt-get calls

Only the second command (apt-get install) is checked.
If apt-get update fails (network issues, …​) the script keeps running.

linux_install_pre() {
-    sudo apt-get update
-    sudo apt-get install --no-install-recommends --no-install-suggests -y curl git ccze jq tmux bc
-    exit_on_error $?
+    sudo apt-get update
+    exit_on_error $? "apt-get update"
+
+    sudo apt-get install --no-install-recommends --no-install-suggests -y \
+         curl git ccze jq tmux bc
+    exit_on_error $? "apt-get install prerequisite packages"
 }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

linux_install_pre() {
    sudo apt-get update
    exit_on_error $? "apt-get update"

    sudo apt-get install --no-install-recommends --no-install-suggests -y \
         curl git ccze jq tmux bc
    exit_on_error $? "apt-get install prerequisite packages"
}

---

35-42: 🛠️ Refactor suggestion

Fix exit_on_error – array handling & quoting

$@:2 assigns an array into a scalar (SC2124).
Switch to proper shifting and quote variables so the original command is echoed
exactly as executed.

-exit_on_error() {
-    exit_code=$1
-    last_command="${@:2}"
-    if [ $exit_code -ne 0 ]; then
-        >&2 echo "\"${last_command}\" command failed with exit code ${exit_code}."
-        exit $exit_code
-    fi
-}
+exit_on_error() {
+    local exit_code="$1"
+    shift                         # keep the failing command intact
+    local last_command="$*"
+    if [ "$exit_code" -ne 0 ]; then
+        >&2 echo "\"${last_command}\" failed with exit code ${exit_code}."
+        exit "$exit_code"
+    fi
+}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

exit_on_error() {
    local exit_code="$1"
    shift                         # keep the failing command intact
    local last_command="$*"
    if [ "$exit_code" -ne 0 ]; then
        >&2 echo "\"${last_command}\" failed with exit code ${exit_code}."
        exit "$exit_code"
    fi
}

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 37-37: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

(SC2124)

deploy-lighthouse-reth.py (2)

382-405: ⚠️ Potential issue

Missing checksum / signature verification for downloaded binaries

The script downloads binaries over HTTPS and executes/moves them without
verifying signatures or hashes. A compromised GitHub CDN edge could deliver
malicious payloads.

At minimum, retrieve the SHA256 provided in the GitHub release and compare
before extraction; ideally verify PGP signatures if available.
[security]

---

240-246: ⚠️ Potential issue

Port-validation regex allows “:?” typo

(:?\d{1,5})? makes the colon optional, so an address like
http://10.0.0.1 without a colon but followed by digits elsewhere in the
string could pass. Use an explicit colon:

-    pattern = r"^(http|https|ws):\/\/((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(:?\d{1,5})?$"
+    pattern = r"^(http|https|ws):\/\/((25[0-5]|2[0-4][0-9]|[01]?\d\d?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?\d\d?)(:\d{1,5})?$"

This keeps the semantics (“port is optional, but if present must start with
:”).
Optionally consider accepting hostnames as well.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

def validate_beacon_node_address(ip_port):
    pattern = r"^(http|https|ws):\/\/((25[0-5]|2[0-4][0-9]|[01]?\d\d?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?\d\d?)(:\d{1,5})?$"
    if re.match(pattern, ip_port):
        return True
    else:
        return False

🧰 Tools

🪛 Ruff (0.8.2)

242-245: Return the condition bool(re.match(pattern, ip_port)) directly

Replace with return bool(re.match(pattern, ip_port))

(SIM103)

install-lighthouse-reth.sh (1)

124-128: Guard against cd failure when clone fallback runs
This is the same SC2164 issue flagged previously: if git clone fails for a
reason other than “directory exists”, the cd will leave the script in an
undefined state.

- git clone … || (cd ~/git/ethpillar ; git fetch …)
+ git clone … || (cd ~/git/ethpillar || exit 1 ; git fetch …)

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 126-126: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

deploy-lighthouse-reth.py (1)

17-35: 🛠️ Refactor suggestion

Cull unused & wildcard imports – they hide bugs and slow startup

The import block pulls in duplicates (random, tempfile), many unused modules
(fnmatch, shutil, urllib.request, zipfile, yaml, dotenv_values) and
several * imports. This:

1. Masks undefined-name errors (star imports pollute the namespace).
2. Bloats memory/start-up time.
3. Violates PEP-8 and Ruff F4xx rules.

Suggested clean-up (minimal):

-import fnmatch
-import random
-import json
-import tarfile
-import shutil
-import subprocess
-import tempfile
-import urllib.request
-import zipfile
-import random
-import sys
-import platform
-import tempfile
-import yaml
-from consolemenu import *
-from consolemenu.items import *
-import argparse
-from dotenv import load_dotenv, dotenv_values
-from config import *
-from tqdm import tqdm
+import argparse
+import json
+import os
+import platform
+import random
+import subprocess
+import sys
+import tarfile
+import tempfile
+from consolemenu import SelectionMenu, PromptUtils, Screen
+from consolemenu.items import FunctionItem
+from dotenv import load_dotenv
+from tqdm import tqdm
+from config import (
+    mainnet_sync_urls,
+    holesky_sync_urls,
+    hoodi_sync_urls,
+    sepolia_sync_urls,
+    ephemery_sync_urls,
+    mainnet_relay_options,
+    holesky_relay_options,
+    hoodi_relay_options,
+    sepolia_relay_options,
+)

Removing the unused names will let static-analysis catch genuine mistakes and
makes maintenance easier.

🧰 Tools

🪛 Ruff (0.8.2)

17-17: fnmatch imported but unused

Remove unused import: fnmatch

(F401)

---

21-21: shutil imported but unused

Remove unused import: shutil

(F401)

---

24-24: urllib.request imported but unused

Remove unused import: urllib.request

(F401)

---

25-25: zipfile imported but unused

Remove unused import: zipfile

(F401)

---

26-26: Redefinition of unused random from line 18

Remove definition: random

(F811)

---

29-29: Redefinition of unused tempfile from line 23

Remove definition: tempfile

(F811)

---

30-30: yaml imported but unused

Remove unused import: yaml

(F401)

---

31-31: from consolemenu import * used; unable to detect undefined names

(F403)

---

32-32: from consolemenu.items import * used; unable to detect undefined names

(F403)

---

34-34: dotenv.dotenv_values imported but unused

Remove unused import: dotenv.dotenv_values

(F401)

---

35-35: from config import * used; unable to detect undefined names

(F403)

deploy-lighthouse-reth.py (1)

280-297: Avoid shell=True with interpolated paths – use arg-lists instead

setup_ephemery_network() executes several sudo rm -rf and mkdir commands
through subprocess.run([...], shell=True) with string concatenation:

subprocess.run([f'sudo rm -rf {testnet_dir}'], shell=True)

Although testnet_dir is internally defined, this pattern invites accidental
shell-injection bugs and disables subprocess’s argument escaping.

- subprocess.run([f'sudo rm -rf {testnet_dir}'], shell=True)
+ subprocess.run(['sudo', 'rm', '-rf', testnet_dir], check=True)

Apply the same change to the subsequent mkdir/chmod calls and any other
os.system usages for safer, more readable code.

install-lighthouse-reth.sh (2)

115-120: ⚠️ Potential issue

Virtual-env is created, but the deployment runs with the system Python

You install packages into ~/.local’s venv (~/.local/bin/pip …) yet later invoke
$python ~/git/ethpillar/deploy-lighthouse-reth.py, which refers to the global
python3. Modules such as console-menu, dotenv, etc. won’t be visible and the
script will crash with ModuleNotFoundError.

Two minimal fixes:

-    $python -m venv ~/.local --system-site-packages
+    $python -m venv ~/.local
…
-    ~/.local/bin/pip install requests console-menu python-dotenv tqdm
+    ~/.local/bin/pip install --upgrade pip
+    ~/.local/bin/pip install requests console-menu python-dotenv tqdm
…
-    $python ~/git/ethpillar/deploy-lighthouse-reth.py
+    ~/.local/bin/python ~/git/ethpillar/deploy-lighthouse-reth.py

(or source the venv’s activate script).
Failing to switch interpreters makes the whole venv setup moot.

Committable suggestion skipped: line range outside the PR's diff.

---

98-103: 💡 Verification agent

❓ Verification inconclusive

apt-get update is not checked – silent failures break the install later

linux_install_pre() exits on error for the apt-get install call, but a network/DNS hiccup during apt-get update would be ignored and could later cause “package not found” errors.

-linux_install_pre() {
-    sudo apt-get update
-    sudo apt-get install --no-install-recommends --no-install-suggests -y curl git ccze jq tmux bc
-    exit_on_error $?
-}
+linux_install_pre() {
+    sudo apt-get update
+    exit_on_error $? "apt-get update"
+
+    sudo apt-get install --no-install-recommends --no-install-suggests -y \
+        curl git ccze jq tmux bc
+    exit_on_error $? "apt-get install prerequisites"
+}

---

Ensure apt-get update failures are caught before installation

A network or DNS hiccup during sudo apt-get update would be ignored and could lead to subsequent “package not found” errors. Add an explicit exit_on_error check immediately after the update command.

• File: install-lighthouse-reth.sh
• Function: linux_install_pre() (around lines 98–103)

 linux_install_pre() {
-    sudo apt-get update
-    sudo apt-get install --no-install-recommends --no-install-suggests -y curl git ccze jq tmux bc
-    exit_on_error $?
+    sudo apt-get update
+    exit_on_error $? "apt-get update failed"

+    sudo apt-get install --no-install-recommends --no-install-suggests -y \
+        curl git ccze jq tmux bc
+    exit_on_error $? "apt-get install prerequisites failed"
 }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

linux_install_pre() {
    sudo apt-get update
    exit_on_error $? "apt-get update failed"

    sudo apt-get install --no-install-recommends --no-install-suggests -y \
        curl git ccze jq tmux bc
    exit_on_error $? "apt-get install prerequisites failed"
}

deploy-lighthouse-reth.py (1)

745-749: ⚠️ Potential issue

Fallback beacon-node URL may expand to http://None:<port>

When the user skips prompts and provides neither --vc_only_bn_address nor
CL_IP_ADDRESS in the .env, the else-branch builds:

_beaconnodeparameters = f'--beacon-nodes=http://{CL_IP_ADDRESS}:{CL_REST_PORT}'

If CL_IP_ADDRESS is unset, this yields an invalid URL and the validator client
exits immediately. Consider:

-if CL_IP_ADDRESS:
-    _beaconnodeparameters = f'--beacon-nodes=http://{CL_IP_ADDRESS}:{CL_REST_PORT}'
-else:
-    _beaconnodeparameters = '--beacon-nodes=http://127.0.0.1:5052'
+_beaconnodeparameters = (
+    f'--beacon-nodes=http://{CL_IP_ADDRESS}:{CL_REST_PORT}'
+    if CL_IP_ADDRESS
+    else '--beacon-nodes=http://127.0.0.1:5052'
+)

to ensure a valid default.

install-lighthouse-reth.sh (1)

126-126: ⚠️ Potential issue

Guard against a failed cd command to avoid masking errors

The cd command can fail silently if the directory doesn't exist, causing subsequent commands to execute in the wrong directory.

Apply this change to handle errors properly:

-git clone https://github.com/coincashew/ethpillar.git ~/git/ethpillar 2> /dev/null || (cd ~/git/ethpillar ; git fetch origin main ; git checkout main ; git pull)
+git clone https://github.com/coincashew/ethpillar.git ~/git/ethpillar 2> /dev/null || (cd ~/git/ethpillar || exit 1 ; git fetch origin main ; git checkout main ; git pull)

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 126-126: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

deploy-lighthouse-reth.py (1)

14-36: 🛠️ Refactor suggestion

Prune unused and duplicate imports

Several modules are imported but never used, and there are duplicate imports that could cause confusion.

Clean up the imports section:

import os
import requests
import re
-import fnmatch
import random
import json
import tarfile
-import shutil
import subprocess
import tempfile
-import urllib.request
-import zipfile
-import random
import sys
import platform
-import tempfile
-import yaml
-from consolemenu import *
-from consolemenu.items import *
+from consolemenu import SelectionMenu, PromptUtils, Screen
+from consolemenu.items import FunctionItem
import argparse
-from dotenv import load_dotenv, dotenv_values
+from dotenv import load_dotenv
-from config import *
+# Import symbols from config explicitly
+from config import (
+    mainnet_sync_urls, holesky_sync_urls, hoodi_sync_urls,
+    sepolia_sync_urls, ephemery_sync_urls, mainnet_relay_options,
+    holesky_relay_options, hoodi_relay_options, sepolia_relay_options
+)
from tqdm import tqdm

🧰 Tools

🪛 Ruff (0.8.2)

17-17: fnmatch imported but unused

Remove unused import: fnmatch

(F401)

---

21-21: shutil imported but unused

Remove unused import: shutil

(F401)

---

24-24: urllib.request imported but unused

Remove unused import: urllib.request

(F401)

---

25-25: zipfile imported but unused

Remove unused import: zipfile

(F401)

---

26-26: Redefinition of unused random from line 18

Remove definition: random

(F811)

---

29-29: Redefinition of unused tempfile from line 23

Remove definition: tempfile

(F811)

---

30-30: yaml imported but unused

Remove unused import: yaml

(F401)

---

31-31: from consolemenu import * used; unable to detect undefined names

(F403)

---

32-32: from consolemenu.items import * used; unable to detect undefined names

(F403)

---

34-34: dotenv.dotenv_values imported but unused

Remove unused import: dotenv.dotenv_values

(F401)

---

35-35: from config import * used; unable to detect undefined names

(F403)

install-lighthouse-reth.sh (2)

35-42: Fix parameter assignment in exit_on_error

The array assignment syntax uses ${@:2} which can cause issues with word splitting.

Consider using this improved version:

exit_on_error() {
    exit_code=$1
-    last_command="${@:2}"
+    shift
+    last_command="$*"
    if [ $exit_code -ne 0 ]; then
        >&2 echo "\"${last_command}\" command failed with exit code ${exit_code}."
        exit $exit_code
    fi
}

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 37-37: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

(SC2124)

---

72-76: Remove unused terminal color variables

The variables tty_underline and tty_red are defined but never used in the script.

Consider removing these unused variables or documenting why they are kept for future use:

tty_mkbold() { tty_escape "1;$1"; }
-tty_underline="$(tty_escape "4;39")"
tty_blue="$(tty_mkbold 34)"
-tty_red="$(tty_mkbold 31)"
tty_bold="$(tty_mkbold 39)"
tty_reset="$(tty_escape 0)"

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 72-72: tty_underline appears unused. Verify use (or export if used externally).

(SC2034)

---

[warning] 74-74: tty_red appears unused. Verify use (or export if used externally).

(SC2034)

deploy-lighthouse-reth.py (5)

240-245: Simplify the beacon node address validation function

The validation function can be more concise.

Simplify the function:

def validate_beacon_node_address(ip_port):
    pattern = r"^(http|https|ws):\/\/((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(:?\d{1,5})?$"
-    if re.match(pattern, ip_port):
-        return True
-    else:
-        return False
+    return bool(re.match(pattern, ip_port))

🧰 Tools

🪛 Ruff (0.8.2)

242-245: Return the condition bool(re.match(pattern, ip_port)) directly

Replace with return bool(re.match(pattern, ip_port))

(SIM103)

---

353-353: Use simplified boolean condition syntax

Instead of comparing boolean values to True or False, use the boolean values directly.

Apply this pattern throughout the code:

-if MEVBOOST_ENABLED == True and not VALIDATOR_ONLY:
+if MEVBOOST_ENABLED and not VALIDATOR_ONLY:

Also on lines 824, 854, and other similar instances.

🧰 Tools

🪛 Ruff (0.8.2)

353-353: Avoid equality comparisons to True; use if MEVBOOST_ENABLED: for truth checks

Replace with MEVBOOST_ENABLED

(E712)

---

690-693: Use ternary operator for simpler boolean assignments

Several if-else blocks could be simplified using Python's ternary operator.

Simplify conditional assignments:

-if MEVBOOST_ENABLED:
-    _mevparameters='--builder http://127.0.0.1:18550'
-else:
-    _mevparameters=''
+_mevparameters = '--builder http://127.0.0.1:18550' if MEVBOOST_ENABLED else ''

Apply similar simplifications for other ternary-convertible blocks on lines 735-738, 740-743, etc.

🧰 Tools

🪛 Ruff (0.8.2)

690-693: Use ternary operator _mevparameters = '--builder http://127.0.0.1:18550' if MEVBOOST_ENABLED else '' instead of if-else-block

Replace if-else-block with _mevparameters = '--builder http://127.0.0.1:18550' if MEVBOOST_ENABLED else ''

(SIM108)

---

751-757: Remove unused bootnodes variable in Ephemery network setup

The bootnodes variable is assigned but never used in this code block.

if eth_network=="ephemery":
    file_path = f"/opt/ethpillar/testnet/bootstrap_nodes.txt"
    with open(file_path, "r") as file:
-        bootnodes = ",".join(file.read().splitlines())
+        # This variable isn't used - remove or use it in _network
    _network=f"--testnet-dir=/opt/ethpillar/testnet"
else:
    _network=f"--network={eth_network}"

🧰 Tools

🪛 Ruff (0.8.2)

752-752: f-string without any placeholders

Remove extraneous f prefix

(F541)

---

754-754: Local variable bootnodes is assigned to but never used

Remove assignment to unused variable bootnodes

(F841)

---

755-755: f-string without any placeholders

Remove extraneous f prefix

(F541)

---

419-423: Remove unnecessary f-string prefixes

There are many f-strings without any expressions that could be simplified to regular strings.

For example:

-os.system(f"sudo mv mev-boost /usr/local/bin")
+os.system("sudo mv mev-boost /usr/local/bin")

-os.system(f"rm {tar_filename} LICENSE README.md")
+os.system(f"rm {tar_filename} LICENSE README.md")  # Keep this as f-string since it has a variable

Apply this change throughout the code where f-strings don't contain any expressions (lines 231, 252, 270, etc.).

🧰 Tools

🪛 Ruff (0.8.2)

420-420: f-string without any placeholders

Remove extraneous f prefix

(F541)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

install-lighthouse-reth.sh (1)

123-127: Still missing a cd … || exit guard – identical to earlier review
The fallback path after a failed git clone can attempt cd ~/git/ethpillar even when the directory doesn’t exist, masking the real error.

-git clone https://github.com/coincashew/ethpillar.git ~/git/ethpillar 2> /dev/null || (cd ~/git/ethpillar ; git fetch origin main ; git checkout main ; git pull)
+git clone https://github.com/coincashew/ethpillar.git ~/git/ethpillar 2>/dev/null \
+  || (cd ~/git/ethpillar || exit 1 ; git fetch origin main ; git checkout main ; git pull)

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 126-126: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

deploy-lighthouse-reth.py (1)

14-37: 🛠️ Refactor suggestion

Prune unused & wildcard imports to unblock static analysis and cut startup time
Many of the imports are unused or duplicated (random, tempfile), and from … import * hides undefined-name errors.

-import fnmatch
-import random
-import json
-import tarfile
-import shutil
-import subprocess
-import tempfile
-import urllib.request
-import zipfile
-import random
-import sys
-import platform
-import tempfile
-import yaml
-from consolemenu import *
-from consolemenu.items import *
-import argparse
-from dotenv import load_dotenv, dotenv_values
-from config import *
-from tqdm import tqdm
+import argparse
+import json
+import os
+import platform
+import re
+import subprocess
+import sys
+import tarfile
+import tempfile
+
+import requests
+from consolemenu import SelectionMenu, PromptUtils, Screen
+from consolemenu.items import FunctionItem
+from dotenv import load_dotenv
+from tqdm import tqdm
+
+# Explicit symbols from config.py
+from config import (
+    mainnet_sync_urls,
+    holesky_sync_urls,
+    hoodi_sync_urls,
+    sepolia_sync_urls,
+    ephemery_sync_urls,
+    mainnet_relay_options,
+    holesky_relay_options,
+    hoodi_relay_options,
+    sepolia_relay_options,
+)

Benefits:
• Ruff / flake8 stop flagging ~40 errors.
• Start-up is faster and memory footprint smaller.
• Undefined names become visible.

🧰 Tools

🪛 Ruff (0.8.2)

17-17: fnmatch imported but unused

Remove unused import: fnmatch

(F401)

---

21-21: shutil imported but unused

Remove unused import: shutil

(F401)

---

24-24: urllib.request imported but unused

Remove unused import: urllib.request

(F401)

---

25-25: zipfile imported but unused

Remove unused import: zipfile

(F401)

---

26-26: Redefinition of unused random from line 18

Remove definition: random

(F811)

---

29-29: Redefinition of unused tempfile from line 23

Remove definition: tempfile

(F811)

---

30-30: yaml imported but unused

Remove unused import: yaml

(F401)

---

31-31: from consolemenu import * used; unable to detect undefined names

(F403)

---

32-32: from consolemenu.items import * used; unable to detect undefined names

(F403)

---

34-34: dotenv.dotenv_values imported but unused

Remove unused import: dotenv.dotenv_values

(F401)

---

35-35: from config import * used; unable to detect undefined names

(F403)

install-lighthouse-reth.sh (1)

35-42: Handle $@ safely to avoid SC2124 and incorrect command echoing
last_command="${@:2}" stores an array into a scalar, which (a) triggers shellcheck SC2124 and (b) collapses arguments containing spaces. Prefer "${*:2}" (concatenate with word-splitting preserved) or quote-join the array.

-last_command="${@:2}"
+last_command="${*:2}"

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 37-37: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

(SC2124)

deploy-lighthouse-reth.py (2)

335-341: Avoid shell=True with a list argument and unquoted variable interpolation
subprocess.run([f'sudo mkdir -p $(dirname {JWTSECRET_PATH})'], shell=True) passes a list while shell=True expects a string. It also risks word-splitting if the path contains spaces.

-subprocess.run([f'sudo mkdir -p $(dirname {JWTSECRET_PATH})'], shell=True)
+subprocess.run(f"sudo mkdir -p \"$(dirname \"{JWTSECRET_PATH}\")\"", shell=True, check=True)

Using check=True immediately propagates errors.

---

741-749: String concatenation leaves leading spaces in command – minor but pollutes journal
When _feeparameters or _mevparameters are empty, the resulting string fed to systemd has doubled spaces. You can inline with conditional expressions to remove trailing blanks:

graffiti     = f"--graffiti={GRAFFITI}"
fee_param    = f"--suggested-fee-recipient={FEE_RECIPIENT_ADDRESS}" if FEE_RECIPIENT_ADDRESS else ""
mev_param    = "--builder-proposals" if MEVBOOST_ENABLED else ""
beacon_param = f"--beacon-nodes={BN_ADDRESS or f'http://{CL_IP_ADDRESS}:{CL_REST_PORT}'}"

ExecStart=/usr/local/bin/lighthouse vc {network} {graffiti} {beacon_param} {fee_param} {mev_param}

Cleaner service files aid troubleshooting.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

install-lighthouse-reth.sh (1)

126-126: 🛠️ Refactor suggestion

Guard against cd failure when the clone falls back

When the first git clone attempt fails, the script tries to CD to the directory and update it. If the directory doesn't exist (for reasons other than "already cloned"), the CD command would fail silently and potentially mask the original error.

Apply this fix to make failures explicit:

-git clone https://github.com/coincashew/ethpillar.git ~/git/ethpillar 2> /dev/null || (cd ~/git/ethpillar ; git fetch origin main ; git checkout main ; git pull)
+git clone https://github.com/coincashew/ethpillar.git ~/git/ethpillar 2> /dev/null || (cd ~/git/ethpillar || exit 1 ; git fetch origin main ; git checkout main ; git pull)

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 126-126: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

deploy-lighthouse-reth.py (3)

124-137: ⚠️ Potential issue

Verify network parameter in non-interactive mode

If --skip_prompts is used without specifying a network, eth_network will be an empty string, causing problems later.

Add validation for required parameters:

if not args.network and not args.skip_prompts:
    # Ask the user for Ethereum network
    index = SelectionMenu.get_selection(valid_networks,title='Node Install Quickstart :: CoinCashew.com',subtitle='Installs Reth EL / Lighthouse BN / Lighthouse VC / MEVboost\nSelect Ethereum network:')

    # Exit selected
    if index == len(valid_networks):
        exit(0)

    # Set network
    eth_network=valid_networks[index]
    eth_network=eth_network.lower()
else:
    eth_network=args.network.lower()
+    # Validate network in non-interactive mode
+    if args.skip_prompts and not eth_network:
+        print("Error: --network is required when using --skip_prompts")
+        exit(1)

🧰 Tools

🪛 Ruff (0.8.2)

126-126: SelectionMenu may be undefined, or defined from star imports

(F405)

---

55-68: 🛠️ Refactor suggestion

Add defaults for environment variables to prevent None in service files

When environment variables are missing, os.getenv() returns None, which could end up in systemd service files as literal "None" strings, causing services to fail.

Add default values for critical parameters:

# Set options to parsed arguments
-EL_P2P_PORT=os.getenv('EL_P2P_PORT')
-EL_P2P_PORT_2=os.getenv('EL_P2P_PORT_2')
-EL_RPC_PORT=os.getenv('EL_RPC_PORT')
+EL_P2P_PORT=os.getenv('EL_P2P_PORT', '30303')
+EL_P2P_PORT_2=os.getenv('EL_P2P_PORT_2', '30304')
+EL_RPC_PORT=os.getenv('EL_RPC_PORT', '8551')
EL_MAX_PEER_COUNT=int(os.getenv('EL_MAX_PEER_COUNT', '50'))
-CL_P2P_PORT=os.getenv('CL_P2P_PORT')
-CL_P2P_PORT_2=os.getenv('CL_P2P_PORT_2')
-CL_REST_PORT=os.getenv('CL_REST_PORT')
-CL_MAX_PEER_COUNT=os.getenv('CL_MAX_PEER_COUNT')
-CL_IP_ADDRESS=os.getenv('CL_IP_ADDRESS')
-JWTSECRET_PATH=os.getenv('JWTSECRET_PATH')
-GRAFFITI=os.getenv('GRAFFITI')
+CL_P2P_PORT=os.getenv('CL_P2P_PORT', '9000')
+CL_P2P_PORT_2=os.getenv('CL_P2P_PORT_2', '9001')
+CL_REST_PORT=os.getenv('CL_REST_PORT', '5052')
+CL_MAX_PEER_COUNT=os.getenv('CL_MAX_PEER_COUNT', '50')
+CL_IP_ADDRESS=os.getenv('CL_IP_ADDRESS', '127.0.0.1')
+JWTSECRET_PATH=os.getenv('JWTSECRET_PATH', '/secrets/jwtsecret')
+GRAFFITI=os.getenv('GRAFFITI', 'ethPillar/coincashew')

---

17-35: 🛠️ Refactor suggestion

Prune unused and duplicate imports

Several modules are imported but never used, and wildcard imports make it difficult to trace where names are coming from.

Clean up imports for better maintainability:

import os
import requests
import re
-import fnmatch
import random
import json
import tarfile
-import shutil
import subprocess
import tempfile
-import urllib.request
-import zipfile
-import random
import sys
import platform
-import tempfile
-import yaml
-from consolemenu import *
-from consolemenu.items import *
+from consolemenu import SelectionMenu, PromptUtils, Screen
+from consolemenu.items import FunctionItem
import argparse
-from dotenv import load_dotenv, dotenv_values
-from config import *
+from dotenv import load_dotenv
+# Import specific names from config instead of using wildcard
+from config import (
+    mainnet_sync_urls, holesky_sync_urls, hoodi_sync_urls,
+    sepolia_sync_urls, ephemery_sync_urls, 
+    mainnet_relay_options, holesky_relay_options,
+    hoodi_relay_options, sepolia_relay_options
+)
from tqdm import tqdm

🧰 Tools

🪛 Ruff (0.8.2)

17-17: fnmatch imported but unused

Remove unused import: fnmatch

(F401)

---

21-21: shutil imported but unused

Remove unused import: shutil

(F401)

---

24-24: urllib.request imported but unused

Remove unused import: urllib.request

(F401)

---

25-25: zipfile imported but unused

Remove unused import: zipfile

(F401)

---

26-26: Redefinition of unused random from line 18

Remove definition: random

(F811)

---

29-29: Redefinition of unused tempfile from line 23

Remove definition: tempfile

(F811)

---

30-30: yaml imported but unused

Remove unused import: yaml

(F401)

---

31-31: from consolemenu import * used; unable to detect undefined names

(F403)

---

32-32: from consolemenu.items import * used; unable to detect undefined names

(F403)

---

34-34: dotenv.dotenv_values imported but unused

Remove unused import: dotenv.dotenv_values

(F401)

---

35-35: from config import * used; unable to detect undefined names

(F403)

install-lighthouse-reth.sh (2)

72-74: Remove unused terminal formatting variables

These formatting variables are defined but never used in the script.

-tty_underline="$(tty_escape "4;39")"
-tty_red="$(tty_mkbold 31)"
+# Remove if unused or keep for potential future use

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 72-72: tty_underline appears unused. Verify use (or export if used externally).

(SC2034)

---

[warning] 74-74: tty_red appears unused. Verify use (or export if used externally).

(SC2034)

---

37-37: Consider using the correct array assignment syntax

The current syntax assigns an array expansion to a string variable, which works but isn't ideal.

If you need the arguments as a string, be explicit:

-last_command="${@:2}"
+# Option 1: Keep as string, but be explicit
+last_command="$(printf '%s ' "${@:2}")"
+# Option 2: Use as array if you need to preserve argument structure
+last_command=("${@:2}")

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 37-37: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

(SC2124)

deploy-lighthouse-reth.py (3)

231-231: Remove unnecessary f-string prefixes

Several strings have an f prefix but don't contain any expressions to evaluate.

Remove unnecessary f prefixes from strings that don't use interpolation:

-    FEE_RECIPIENT_ADDRESS = Screen().input(f'Enter your Ethereum address (aka Fee Recipient Address)\n Hints: \n - Use ETH adddress from a hardware wallet.\n - Do not use an exchange address.\n > ')
+    FEE_RECIPIENT_ADDRESS = Screen().input('Enter your Ethereum address (aka Fee Recipient Address)\n Hints: \n - Use ETH adddress from a hardware wallet.\n - Do not use an exchange address.\n > ')

-        BN_ADDRESS = Screen().input(f'\nEnter your consensus client (beacon node) address.\nExample: http://192.168.1.123:5052\n > ')
+        BN_ADDRESS = Screen().input('\nEnter your consensus client (beacon node) address.\nExample: http://192.168.1.123:5052\n > ')

-    answer=PromptUtils(Screen()).prompt_for_yes_or_no(f'{message}')
+    answer=PromptUtils(Screen()).prompt_for_yes_or_no(message)

Also applies to: 252-252, 273-273

🧰 Tools

🪛 Ruff (0.8.2)

231-231: Screen may be undefined, or defined from star imports

(F405)

---

231-231: f-string without any placeholders

Remove extraneous f prefix

(F541)

---

690-693: Use ternary operators for cleaner conditional assignments

The code can be simplified using ternary operators where appropriate.

Simplify conditional assignments:

-        if MEVBOOST_ENABLED:
-            _mevparameters='--builder http://127.0.0.1:18550'
-        else:
-            _mevparameters=''
+        _mevparameters = '--builder http://127.0.0.1:18550' if MEVBOOST_ENABLED else ''

-    if MEVBOOST_ENABLED:
-        _mevparameters='--builder-proposals'
-    else:
-        _mevparameters=''
+    _mevparameters = '--builder-proposals' if MEVBOOST_ENABLED else ''

Also applies to: 735-738

🧰 Tools

🪛 Ruff (0.8.2)

690-693: Use ternary operator _mevparameters = '--builder http://127.0.0.1:18550' if MEVBOOST_ENABLED else '' instead of if-else-block

Replace if-else-block with _mevparameters = '--builder http://127.0.0.1:18550' if MEVBOOST_ENABLED else ''

(SIM108)

---

828-828: Use Pythonic boolean syntax

Using NODE_ONLY == False is less idiomatic than not NODE_ONLY.

-    if NODE_ONLY == False:
+    if not NODE_ONLY:

🧰 Tools

🪛 Ruff (0.8.2)

828-828: Avoid equality comparisons to False; use if not NODE_ONLY: for false checks

Replace with not NODE_ONLY

(E712)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro