Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Sep 8, 2024

closes #1395

In addition to the post's body, we now save (all fields are optional, so we only save them if the context allows for it):

  • post title;
  • post tags;
  • post license;
  • edit comment ;
  • tag wiki;
  • tag excerpt;
  • tag name;

Those fields are stored individually, I opted to do so to not invalidate drafts created prior to the change, but open to switching to a hash value instead.

@Oaphi Oaphi self-assigned this Sep 8, 2024
@Oaphi Oaphi requested a review from a team September 8, 2024 17:06
@Oaphi Oaphi marked this pull request as ready for review September 9, 2024 13:24
@ws909
Copy link
Contributor

ws909 commented Sep 9, 2024

I can't see a mention of tag synonyms, tag name ("post title" covers that, maybe?), and parent tag. Are these three included?

@Oaphi
Copy link
Member Author

Oaphi commented Sep 9, 2024

I can't see a mention of tag synonyms, tag name ("post title" covers that, maybe?), and parent tag. Are these three included?

Parent tag and synonyms are a no-go for now, I tried, but the scope of the change required to support them would be quite significant (they are loaded in a very different manner as opposed to post tags), so probably some time later as a separate improvement. As for the name, yeah, seems to be worth adding.

@ws909
Copy link
Contributor

ws909 commented Sep 9, 2024

In that case, this might be related:
500, internal server error, as I try to create a tag

@Oaphi
Copy link
Member Author

Oaphi commented Sep 9, 2024

In that case, this might be related: 500, internal server error, as I try to create a tag

I don't think this one's in scope of the change either, there is an issue open to address that (#1353). I may be the one fixing it, or maybe not, depending on what my availability is. Doesn't seem like something that would be hard to solve, though.

@ws909
Copy link
Contributor

ws909 commented Sep 9, 2024

I meant that it may be related to the way that synonyms and parent tag are implemented, not that they're in scope here, after you ruled those two out. But it seems you've located the issue, then, and that the problem is that the system tries searching for the synonyms before creating the tag.

@Oaphi
Copy link
Member Author

Oaphi commented Sep 9, 2024

@ws909 ah, I thought you wanted me to make the change in this PR, sorry. If I get some time to spare, will look into it, just not as part of this change to avoid scope creep.

@Oaphi Oaphi added area: backend Changes to server-side code area: frontend Changes to front-end code complexity: average Not particularly hard, not particularly trivial. labels Sep 12, 2024
@Oaphi Oaphi requested a review from ArtOfCode- September 20, 2024 03:20
@cellio
Copy link
Member

cellio commented Sep 24, 2024

@ArtOfCode- did the updates here address your concerns?

@ArtOfCode-
Copy link
Member

LGTM

@cellio cellio merged commit 4929f9f into develop Sep 24, 2024
@cellio cellio deleted the 0valt/1395/drafts branch September 24, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Changes to server-side code area: frontend Changes to front-end code complexity: average Not particularly hard, not particularly trivial.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When saving drafts for posts, we should also save the title and tags

5 participants