Skip to content

Latest release crashes on HPRC v1.1 MC graphs #16

@glennhickey

Description

@glennhickey

To reproduce

wget -q https://public.gi.ucsc.edu/~hickey/debug/gfaffix2-crash/chr11.vg.gfa.gz
gzip -d chr11.vg.gfa.gz
RUST_BACKTRACE=1 GFAffix-0.2.0_linux_x86_64/gfaffix  chr11.vg.gfa --output_refined chr11.vg.old-gfaffixed.gfa --check_transformation --dont_collapse 'CHM13#[.]*'
[2025-01-20T15:52:24Z INFO  gfaffix] running gfaffix on 1 threads
[2025-01-20T15:52:24Z INFO  gfaffix] loading graph from chr11.vg.gfa
[2025-01-20T15:52:58Z INFO  gfaffix] constructing handle graph
[2025-01-20T15:53:04Z INFO  gfaffix] handlegraph has 3539979 nodes and 4885244 edges
[2025-01-20T15:53:04Z INFO  gfaffix] storing length of original nodes for bookkeeping
[2025-01-20T15:53:07Z INFO  gfaffix] flagging nodes of path CHM13#0#chr11:0-135127769$gfaffix as non-collapsing, total number is now at 2238554
[2025-01-20T15:53:07Z INFO  gfaffix] identifying walk-preserving shared affixes
[2025-01-20T15:53:33Z INFO  gfaffix] found and collapsed 9887 shared prefixes, 1287 of which are overlapping, and 4862 of which are bubbles
[2025-01-20T15:53:33Z INFO  gfaffix] de-collapse no-collapse handles and update transformation table
thread 'main' panicked at src/collapse_event_tracker.rs:330:9:
get_collapsed_nodes produced either too many decollapses or to few: 
>97790:1 = 2
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/panicking.rs:74:14
   2: gfaffix::collapse_event_tracker::CollapseEventTracker::get_collapsed_nodes
             at /Users/ddoerr/Documents/CoDia/projects/gfaffix/src/collapse_event_tracker.rs:330:9
   3: gfaffix::collapse_event_tracker::CollapseEventTracker::decollapse
             at /Users/ddoerr/Documents/CoDia/projects/gfaffix/src/collapse_event_tracker.rs:353:25
   4: gfaffix::main
             at /Users/ddoerr/Documents/CoDia/projects/gfaffix/src/main.rs:1245:9
   5: core::ops::function::FnOnce::call_once
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/ops/function.rs:250:5

Another file can be found here

https://public.gi.ucsc.edu/~hickey/debug/gfaffix2-crash/

It seems to run fine without --dont_collapse. It also works with the previous release (adding P-lines back to the input with vg convert -fW

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions