support set and forget dps #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Related to #420. Does it make sense to have it as a global option for every device instance like it currently is? Or should it be set on a per-SET request basis? |
Contributor
Author
it is fine to have it per-SET, but I guess that is what I have done there |
Owner
|
Sorry for the late response. I've been busy lately but I hope to take a look at this next week. |
codetheweb
approved these changes
Mar 20, 2021
Owner
|
Again, sorry for the wait. This is now published in v6.3.0. I tweaked the name slightly, check the docs for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this helps with some dps such as 27 (music data) which can be exploited as a direct mode for light sources
basic testing is done, but it really needs more testing