-
Notifications
You must be signed in to change notification settings - Fork 506
Letter 'a' from #428 (replaces #430) #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letter 'a' from #428 (replaces #430) #448
Conversation
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 2 2
Lines 665 665
Branches 93 93
=======================================
Hits 584 584
Misses 62 62
Partials 19 19Continue to review full report at Codecov.
|
80a48ea to
6ee00e3
Compare
codespell_lib/data/dictionary.txt
Outdated
| alow->allow | ||
| alowed->allowed | ||
| alowing->allowing | ||
| alowinserts->allowinserts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
codespell_lib/data/dictionary.txt
Outdated
| applicaitons->applications | ||
| applicaten->application | ||
| applicatin->application | ||
| applicationevnet->applicationevent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
327cb65 to
fe7d763
Compare
|
@EdwardBetts do you mind reviewing this PR? Thanks! |
fe7d763 to
ac07542
Compare
|
@larsoner would you like me to further break this PR apart so it's not so large ? |
ac07542 to
a51637a
Compare
|
Now it needs a rebase at least |
a51637a to
c337be3
Compare
|
Done |
codespell_lib/data/dictionary.txt
Outdated
| applictions->applications | ||
| applikation->application | ||
| appling->applying, appalling, | ||
| applyable->applycable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be applyable->applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct sir. Thank you. Will fix and push revision
(FYI: This PR is a revision on codespell-project#430 whereby non-'a' letters have been removed and other tweeks have been made) Started to separate codespell-project#428 in to discrete PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.
c337be3 to
2841ea3
Compare
|
Should be ready for merge, AFAICT |
codespell_lib/data/dictionary.txt
Outdated
| aproximately->approximately | ||
| aproximation->approximation | ||
| aproximations->approximations | ||
| aprrovement->approvement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word approvement is archaic, it isn't known by my the Firefox spell checker. I feel like we shouldn't be encouraging programmers to use it. Approval is a better choice of word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Changed
codespell_lib/data/dictionary.txt
Outdated
| anthromorphization->anthropomorphization | ||
| anthropolgist->anthropologist | ||
| anthropolgy->anthropology | ||
| antialialised->antialialiased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Antialialiased isn't a word, it should be antialiased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed
(FYI: This PR is a revision on #430 whereby non-'a' letters have been removed and other tweeks have been made)
Started to separate #428 in to discrete PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.