Skip to content

Conversation

@bwitt
Copy link
Contributor

@bwitt bwitt commented Sep 21, 2021

Update github action Flake8 with annotations to v2

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a query about pinning to a specific version (and therefore requiring us to keep upgrading in future).

@bwitt bwitt changed the title Update TrueBrain/actions-flake8 to latest and pin flake8 to current latest Update TrueBrain/actions-flake8 github action to v2 Sep 23, 2021
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@peternewman peternewman self-assigned this Sep 23, 2021
@peternewman
Copy link
Collaborator

@DimitriPapadopoulos do you want to re-review too?

@DimitriPapadopoulos
Copy link
Collaborator

Perfect. And indeed if the CI fails on us too often, we may have to reconsider pinning versions.

@peternewman peternewman merged commit 8cbc66d into codespell-project:master Sep 23, 2021
@bwitt bwitt deleted the bwitt-patch-1 branch September 23, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants