Fix LGTM recommendation: Module is imported with 'import' and 'import from' #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from' Module 'os' is imported with both 'import' and 'import from' I feel we don't need this abbreviation here: - Lines are not too long. - os.path is known by all Python developpers, while the op abbreviation is not (I believe the osp abbreviation is more common). And actually we had both os.path.exists() and op.join() in the code. That's confusing.
f99a8ad to
97520c0
Compare
peternewman
approved these changes
Sep 13, 2021
Collaborator
peternewman
left a comment
There was a problem hiding this comment.
LGTM 😆 Seems legit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module '
os' is imported with both 'import' and 'import from'I feel we don't need this
opabbreviation here:os.pathis known by all Python developers, while theopabbreviation is not (I believe theospabbreviation is more common).And actually we had both
os.path.exists()andop.join()in the code. That's confusing.Here is the LGTM alert:
https://lgtm.com/projects/g/codespell-project/codespell/