Add fixes from https://github.com/ggtracker/sc2reader/pull/146 #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luzpaz
approved these changes
Jul 27, 2021
Collaborator
luzpaz
left a comment
There was a problem hiding this comment.
LGTM, though i'm not sure about the commit title. Should we keep or modify?
peternewman
approved these changes
Jul 27, 2021
Collaborator
peternewman
left a comment
There was a problem hiding this comment.
LGTM. It tells us where they come from which works for me.
TBH the commit titles are somewhat irrelevant here IMHO, git blame (where it works) is probably just as useful).
I guess ideally the title would be more descriptive with the link in the description, but 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.