This repository was archived by the owner on Nov 14, 2024. It is now read-only.
chore: add release job and goreleaser config#18
Merged
Conversation
jawnsy
reviewed
Sep 15, 2021
| permissions: | ||
| actions: none | ||
| checks: none | ||
| contents: write |
There was a problem hiding this comment.
I guess this needs contents: write to upload the release? Seems unfortunate that we have to give write permissions to the source code for this token
Member
Author
There was a problem hiding this comment.
Yep, that's my assumption here.
jawnsy
approved these changes
Sep 15, 2021
jawnsy
left a comment
There was a problem hiding this comment.
Nice, thanks for taking care of this! It was on my to-do list, but you got to it first 🏃
jawnsy
reviewed
Sep 15, 2021
| uses: goreleaser/goreleaser-action@v2 | ||
| with: | ||
| # either 'goreleaser' (default) or 'goreleaser-pro' | ||
| distribution: goreleaser |
There was a problem hiding this comment.
Is there some way of making preview releases in PRs so that we know everything will build correctly before we tag it?
Member
Author
There was a problem hiding this comment.
I think we could add something like this as a step in the build stage:
goreleaser release --snapshot --skip-publish --rm-dist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.