Merged
Conversation
249257d to
3afdf39
Compare
Emyrk
approved these changes
Dec 15, 2025
Member
Emyrk
left a comment
There was a problem hiding this comment.
Reading https://learn.microsoft.com/en-us/azure/security/fundamentals/azure-ca-details?tabs=root-and-subordinate-cas-list, I think @code-asher's take makes sense.
It seems some RSA certs were replaced by ECC, and why there are more now.
I think we need to actually test this with some azure instances, and we have to test it after January 6 according to the blog post.
Since no certs are remove, I will approve.
@code-asher can we create an issue to test said certs against a vm after Jan 6?
3afdf39 to
a288971
Compare
Member
Author
|
Opened coder/internal#1198 so we can test after 1/6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these certs expired earlier this year, but I have left them in because I am still not sure I understand the impact or how to test.
We got a notice saying there are new sub-CAs so I went ahead and added all the "issuing" ones but I am not 100% sure this is correct. The documentation is not explicit about which certificates are necessary for signature verification.
@kylecarbs would you happen to have additional context? In the PR the ECC ones were not added and of the RSA ones only the
xsignvariant was included, is that all we need?Closes coder/internal#1147
Edit: decided to add just the ECC
xsignvariants (RSA ones were already bundled). We think these are probably the ones we need (the public key is the same as the non-xsignvariants). However these certs do expire in August, so likely they will need to be replaced soon...