test: add mocked terraform installation files #20757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d73d8a to
4617874
Compare
hugodutka
requested changes
Nov 13, 2025
Contributor
hugodutka
left a comment
There was a problem hiding this comment.
I like the idea to mock the terraform server. When you're refactoring code, please avoid process exec for moving, zipping, and making files executable. We run these tests on multiple OSes, and stuff will be less prone to break if you stick to the go stdlib.
provisioner/terraform/testdata/fake-terraform-installer/setup_fakes.sh
Outdated
Show resolved
Hide resolved
provisioner/terraform/testdata/fake-terraform-installer/setup_fakes.sh
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mocked terraform installation files and uses them in provisioner/terraform.TestInstall
Fixes: coder/internal#72