Merged
Conversation
Since this is for file system paths it feels incorrect to use it on URL paths as they are different in many ways.
Before we relied on the client to resolve the base given to it by the backend against the path. Instead have the client pass that information along so we can resolve it on the backend. This means the client has to do less work.
This is re-used for incremental compilation. Also remove del since that was the only use (and we can use fs.rmdir in the future if we need something like this).
jsjoeio
approved these changes
Dec 8, 2021
Contributor
jsjoeio
left a comment
There was a problem hiding this comment.
This means the client has to do less work.
Favorite part of this whole PR 👏
Codecov Report
@@ Coverage Diff @@
## main #4594 +/- ##
==========================================
- Coverage 65.80% 65.61% -0.19%
==========================================
Files 30 30
Lines 1658 1652 -6
Branches 333 330 -3
==========================================
- Hits 1091 1084 -7
- Misses 479 481 +2
+ Partials 88 87 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4503