Merged
Conversation
Now, instead of processing strings, we work with bytes, which does not lead to an exception when processing some unicode characters, such as emoji. Also, now there is no decoding from utf-8 and vice versa, which can potentially increase performance. The application code has been moved to a function, so it is easier to debug and this is a more pythonic way.
Contributor
Author
|
Fixes nvaccess/nvda#16027 |
Contributor
Author
5 tasks
5 tasks
Owner
|
Changes seem okay! I'll run with this for a while on my end and merge it soon. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, instead of processing strings, we work with bytes, which does not lead to an exception when processing some unicode characters, such as emoji.
Also, now there is no decoding from utf-8 and vice versa, which can potentially increase performance.
The application code has been moved to a function, so it is easier to debug and this is a more pythonic way.