Skip to content

refactor: fix Throttler::check() $tokens #9067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paulbalandan merged 1 commit into from
Jul 25, 2024
Merged

refactor: fix Throttler::check() $tokens #9067

paulbalandan merged 1 commit into from
Jul 25, 2024

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Jul 24, 2024

Description
Fix for PHPStan v1.11.8

------ ------------------------------------------------------------------------------------------------------- 
  Line   system/Throttle/Throttler.php                                                                          
 ------ ------------------------------------------------------------------------------------------------------- 
  :126   Binary operation "+=" between array|bool|float|int|object|string and (float|int) results in an error.  
         🪪  assignOp.invalid                                                                                   
         ✏️  system/Throttle/Throttler.php:126                                                                  
 ------ -------------------------------------------------------------------------------------------------------

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jul 25, 2024
@paulbalandan paulbalandan merged commit da778b5 into codeigniter4:develop Jul 25, 2024
@paulbalandan paulbalandan deleted the phpstan-1.11.8 branch July 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan @kenjis