Skip to content

Conversation

@samsonasik
Copy link
Member

Description

enable AddClosureVoidReturnTypeWhereNoReturnRector to add void return on closure

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

@paulbalandan thank you for the review, let's merge ;)

@samsonasik samsonasik merged commit d14dce8 into codeigniter4:develop Jun 27, 2024
@samsonasik samsonasik deleted the refactor-closure-void branch June 27, 2024 16:09
@kenjis kenjis added the refactor Pull requests that refactor code label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants