Skip to content

fix: [DebugBar] TypeError in Toolbar #8727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenjis merged 3 commits into from
Apr 9, 2024
Merged

fix: [DebugBar] TypeError in Toolbar #8727

kenjis merged 3 commits into from
Apr 9, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Apr 7, 2024 •
edited
Loading

Description
Closes #8730
From https://forum.codeigniter.com/showthread.php?tid=90586&pid=417661#pid417661

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 7, 2024
@kenjis kenjis mentioned this pull request Apr 8, 2024
Closed
@kenjis kenjis changed the title fix: TypeError in Toolbar fix: [DebugBar] TypeError in Toolbar Apr 8, 2024
kenjis added 3 commits April 9, 2024 15:51
@kenjis
docs: fix typo in comment
9fe63a1
@kenjis
docs: add @var for PhpStorm
b19523e
@kenjis
fix: TypeError
fb2980e 
TypeError: str_contains(): Argument #1 ($haystack) must be of type string, null given
@kenjis kenjis force-pushed the fix-Toolbar-response-getBody branch from f2483dc to fb2980e Compare April 9, 2024 06:51
@kenjis kenjis merged commit 17ac8e6 into codeigniter4:develop Apr 9, 2024
@kenjis kenjis deleted the fix-Toolbar-response-getBody branch April 9, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+2 more reviewers

@datamweb datamweb datamweb approved these changes

@ddevsr ddevsr ddevsr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [DebugBar] 4.5.0 TypeError: str_contains(): Argument #1 ($haystack) must be of type string, null given

4 participants

@kenjis @michalsn @datamweb @ddevsr