refactor: [Rector] Apply ExplicitBoolCompareRector #8704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Apr 3, 2024
Member
Author
|
Ready to review 👍 |
paulbalandan
reviewed
Apr 3, 2024
Member
paulbalandan
left a comment
There was a problem hiding this comment.
I'm not sure abt the change in strings to === '' and === '0'. Are we really checking for non-falsy-string? Or maybe just non-empty-string?
For the others, I think I'm good with those changes.
Member
Author
|
This is the exact equal truthy check to string, which should be safer. if it only check on empty string |
kenjis
reviewed
Apr 3, 2024
kenjis
reviewed
Apr 3, 2024
kenjis
reviewed
Apr 3, 2024
kenjis
reviewed
Apr 3, 2024
kenjis
reviewed
Apr 3, 2024
kenjis
reviewed
Apr 3, 2024
kenjis
reviewed
Apr 3, 2024
kenjis
reviewed
Apr 3, 2024
Member
Author
|
@kenjis I updated to remove |
kenjis
approved these changes
Apr 4, 2024
Member
Author
|
Ready to merge 👍 |
paulbalandan
approved these changes
Apr 4, 2024
Member
Author
|
Let's merge it, thank you @paulbalandan @kenjis for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make if conditions more explicit and reduce phpstan baseline errors.
Checklist: