Skip to content

docs: add commnets on Postgre::convertDSN() #8656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenjis merged 1 commit into from
Mar 28, 2024
Merged

docs: add commnets on Postgre::convertDSN() #8656

kenjis merged 1 commit into from
Mar 28, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Mar 25, 2024

Description
I don't know why Postgre driver supports PDO_PGSQL DSN.
It came from 30063c9f#diff-d627f02b770edc4ab06280dbc671681df326dc7790e9bc7b1cf268a5da58e465

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

michalsn
michalsn approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion about it. Some people may use it. I don't see it as a big problem - only as a small inconsistency.

@kenjis kenjis added the database Issues or pull requests that affect the database layer label Mar 27, 2024
@kenjis
Copy link
Member Author

kenjis commented Mar 27, 2024

@codeigniter4/database-team The DSN is not documented.
And there is no need to support it,
because we can use the format like "host=sheep port=5432 dbname=mary user=lamb password=foo".
See https://www.php.net/manual/en/function.pg-connect.php#refsect1-function.pg-connect-examples

@kenjis kenjis merged commit 87652c9 into codeigniter4:develop Mar 28, 2024
@kenjis kenjis deleted the add-comments-to-PDO_PGSQL-DSN branch March 28, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

database Issues or pull requests that affect the database layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @michalsn