[Rector] Testing Rector dev-main#7918
Closed
samsonasik wants to merge 1 commit intocodeigniter4:developfrom
Closed
[Rector] Testing Rector dev-main#7918samsonasik wants to merge 1 commit intocodeigniter4:developfrom
samsonasik wants to merge 1 commit intocodeigniter4:developfrom
Conversation
Member
|
It seems no problem. (test-rector-dev-main-2 $)$ time vendor/bin/rector
821/821 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] Rector is done!
real 6m1.921s
user 12m38.855s
sys 0m30.725s |
Member
|
I still could not test because of the issue in space in path. Sorry. |
staabm
reviewed
Sep 11, 2023
| PHPUnitSetList::PHPUNIT_100, | ||
| ]); | ||
|
|
||
| $rectorConfig->parallel(240, 8, 1); |
There was a problem hiding this comment.
btw: I can't make sense of a jobsize of 1. this should be pretty inefficient. nice its gone with this PR :)
Member
Author
|
Thanks all 👍 , I will update the config on next dependabot PR for new rector release 👍 |
|
Fyi - on my machine the new release is 20-25% faster in my codeigniter tests in comparison to 0.18.2 (with the suggested changes in parallel parameters) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi @kenjis @paulbalandan could you test the rector/rector:dev-main with clean up parallel config below and verify if the performance drawback resolved without setting
$jobSizeconfig in theparallel()config below?If that works, we can remove passing arguments in the
parallel()config in next rector release.Current rector dev-main changed the parallel process by @staabm . I mention you here so you can have fast feedback here in case we found a different use case.
Thank you.
Checklist: