Small Feature: debugbar link#3070
Small Feature: debugbar link#3070MGatner merged 1 commit intocodeigniter4:developfrom enix-app:debugbar-route-link
Conversation
|
This looks pretty cool but I’m not entirely sure from the video what is happening. It turns the route rows into usable and editable links? Please provide a description along with the code, if you would. Also I don’t think we have formatting correction for JavaScript but please make sure it adheres to the style guide: |
MGatner
left a comment
There was a problem hiding this comment.
Provide description and style code.
|
Preview GIF Here, sample routes: $routes->get('/', 'Home::index');
$routes->get('/test', 'Home::index');
$routes->get('/test/(:num)', 'Home::index');
$routes->add('/test/(:num)/(:any)', 'Home::index');
$routes->get('/test/page-(:num)/(:any)', 'Home::index');
$routes->add('/test/page-(:num)/(:any).html', 'Home::index');
|
|
It took me a couple of minutes of before I took to this one, but I do kindof dig this feature. @enix-app if you can fix the style tweaks that MGatner asked, we'll merge. |
|
@lonnieezell & @MGatner , I modified it, tested on old browser IE11. |
MGatner
left a comment
There was a problem hiding this comment.
Still the spaces after if statements. I know it is nitpicking but if they don’t align with the style now then nobody is going to bother to change them later.
| if (input[n].value.length > 0) inputArray.push(input[n].value); | ||
| } | ||
|
|
||
| if(inputArray.length > 0) { |
|
|
||
| for (var i = 0; i < rowGet.length; i++) { | ||
| row = rowGet[i]; | ||
| if(!/\/\(.+?\)/.test(rowGet[i].innerText)) { |
There was a problem hiding this comment.
if (!/\/\(.+?\)/.test(rowGet[i].innerText)) {
|
OOT: I can't login/register to forum website. |
|
Looks great, thank you! |
|
I'm not sure why, but this does not work now. |
I think this useful when we would test or check an URI by click the link without write or copy/paste to address bar. Only GET method.
Support custom placeholder.
Checklist: