Skip to content

Fix issue 2980: Editor changes source line that only contains a number with sign#2982

Merged
chrjorgensen merged 3 commits intocodefori:masterfrom
chrjorgensen:fix/issue-2980
Nov 21, 2025
Merged

Fix issue 2980: Editor changes source line that only contains a number with sign#2982
chrjorgensen merged 3 commits intocodefori:masterfrom
chrjorgensen:fix/issue-2980

Conversation

@chrjorgensen
Copy link
Copy Markdown
Collaborator

Changes

This PR will fix #2980 by ensuring SRCDTA is always interpreted as a string.

Before this PR lines in SRCDTA containing only numbers would be interpreted as number and formatted as numbers.

How to test this PR

  1. Run the case described in Editor changes source line that only contains a number with sign #2980 on the master branch, and notice how numbers are modified.
  2. Run the new test case in this branch, this will succeed.
  3. Run the case described in Editor changes source line that only contains a number with sign #2980 on the master branch, and notice how numbers are no longer modified.

Checklist

  • have tested my change

@chrjorgensen chrjorgensen self-assigned this Nov 20, 2025
@chrjorgensen chrjorgensen added the bug A confirmed issue when something isn't working as intended label Nov 20, 2025
@chrjorgensen chrjorgensen temporarily deployed to testing_environment November 20, 2025 22:59 — with GitHub Actions Inactive
@chrjorgensen chrjorgensen requested a review from a team November 20, 2025 22:59
Copy link
Copy Markdown
Member

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever change!
Just a small change and you can merge 😄

Comment thread src/api/Tools.ts Outdated
Co-authored-by: Sébastien Julliand <sebjulliand@gmail.com>
@chrjorgensen chrjorgensen temporarily deployed to testing_environment November 21, 2025 08:59 — with GitHub Actions Inactive
@chrjorgensen chrjorgensen merged commit f68b795 into codefori:master Nov 21, 2025
2 checks passed
@chrjorgensen chrjorgensen deleted the fix/issue-2980 branch November 21, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor changes source line that only contains a number with sign

2 participants