Skip to content

Add additional check for SIGABRT#2754

Merged
sebjulliand merged 3 commits intomasterfrom
fix/handle_sigabrt
Jun 24, 2025
Merged

Add additional check for SIGABRT#2754
sebjulliand merged 3 commits intomasterfrom
fix/handle_sigabrt

Conversation

@worksofliam
Copy link
Copy Markdown
Member

Looks like there is a bug with our node library. We have an instance when an IBM i system is not setup correctly, then SIGABRT is thrown, but the code is still 0 - which in most of the extension, indicates success.

/home/OLVERA: /home/OLVERA/.vscode/cqsh_1
echo "Hello world"
{
    "code": 0,
    "signal": "SIGABRT",
    "stdout": "",
    "stderr": ""
}

I've added some logic to our statement executor to set the code to 127 when SIGABRT is thrown.

I have also added a page in the docs to track this issue (which we've now seen a couple of times in the wild, but we are still unsure of the cause): https://codefori.github.io/docs/tips/setup/#qsh--cqsh-returning-sigabrt

sebjulliand and others added 3 commits June 17, 2025 15:05
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam requested a review from sebjulliand June 24, 2025 14:55
@worksofliam worksofliam had a problem deploying to testing_environment June 24, 2025 14:55 — with GitHub Actions Failure
@github-actions
Copy link
Copy Markdown
Contributor

👋 A new build is available for this PR based on 88c1c39.

Copy link
Copy Markdown
Member

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebjulliand sebjulliand merged commit 90f4842 into master Jun 24, 2025
4 of 5 checks passed
@sebjulliand sebjulliand deleted the fix/handle_sigabrt branch June 24, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants