Fixed download of members with variant characters#2746
Merged
sebjulliand merged 1 commit intomasterfrom Jun 24, 2025
Merged
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Contributor
|
👋 A new build is available for this PR based on 14e3e14. |
worksofliam
approved these changes
Jun 23, 2025
Member
worksofliam
left a comment
There was a problem hiding this comment.
Changes are good but long term strategy here is to move this logic and using runSql out of the object explorer class and into IBMiContent..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2728
Downloading a member with the
$oràvariant characters would fail because:$was escaped byTools.qualifyPathàwould be uppercased whenCPYTOSTMFwas run (don't know exactly why...it is sent lowercased by us)Using a dummy member name while transferring the member to a stream file fixes both issues.
How to test this PR
$(CSSID 37 or 297) orà(CSSID 297) in its nameChecklist