Show warning for unsupported minimum debug version#2722
Conversation
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
|
👋 A new build is available for this PR based on f9b6ae9. |
sebjulliand
left a comment
There was a problem hiding this comment.
The change by itself is OK.
But do we really want to bother users with a message about upgrading the debugger every time they connect, especially if they can't do anything about it? 😅
I'm thinking we could show the message, and offer two actions: Remind me (show the message next time the user connects), Dismiss (don't show the message ever again). The action taken should be stored in the global storage so it doesn't get synced.
What do you think?
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
|
@sebjulliand Great idea. Take another look and let me know what you think. |
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
sebjulliand
left a comment
There was a problem hiding this comment.
One small change (maybe) and we'll be good to go.
Co-authored-by: Sébastien Julliand <sebjulliand@gmail.com>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
|
@sebjulliand One more time! 😄 |
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
|
I made a change so that the warning only shows if the debug service is actually installed. We don't want to bother people with no debug service 😅 |
Implement a warning message when the debug service version is below the minimum required version, prompting users to update the debug service PTF.
Closes #2719