Skip to content

Run cp and mv in QSH to keep CCSID attribute#2703

Merged
worksofliam merged 2 commits intomasterfrom
fix/copyMoveKeepCCSID
Jun 6, 2025
Merged

Run cp and mv in QSH to keep CCSID attribute#2703
worksofliam merged 2 commits intomasterfrom
fix/copyMoveKeepCCSID

Conversation

@sebjulliand
Copy link
Copy Markdown
Member

@sebjulliand sebjulliand commented May 28, 2025 •
edited
Loading

Changes

Fixes #2696

As explained by @kadler in the IBM i OSS chat, QSH version of cp retain the CCSID of the original file into the copy.
Running the copy and move operations in QSH fixes the issue reported in #2696.

How to test this PR

  • Run the new test case
  • Check from the UI
    1. Create a streamfile with CCSID != 1208 or 819: touch -C 37 testfile
    2. Copy this streamfile using drag and drop in the IFS browser
    3. Copy it also using the right-click Copy action
    4. Check the CCSID of the copied file is 37: attr copyOfTestFile CCSID

Checklist

  • have tested my change

@sebjulliand
Run cp and mv in QSH to keep CCSID attribute
1f970a7 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand requested a review from a team May 28, 2025 21:05
@sebjulliand sebjulliand self-assigned this May 28, 2025
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label May 28, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2025 •
edited
Loading

👋 A new build is available for this PR based on 6077f1e.

@worksofliam
Copy link
Copy Markdown
Member

worksofliam commented May 29, 2025

@sebjulliand do we have any test cases to check for this?

@worksofliam worksofliam added this to the 3.0.0 milestone May 29, 2025
@sebjulliand
Moved copy/move logic out of ifs browser and added unit test
6077f1e 
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand had a problem deploying to testing_environment May 29, 2025 21:26 — with GitHub Actions Failure
@sebjulliand
Copy link
Copy Markdown
Member Author

sebjulliand commented May 29, 2025

@sebjulliand do we have any test cases to check for this?

@worksofliam now we do 😉

worksofliam
worksofliam approved these changes Jun 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a good test. Thanks @sebjulliand!

@worksofliam worksofliam merged commit cafc6e6 into master Jun 6, 2025
4 of 5 checks passed
@sebjulliand sebjulliand deleted the fix/copyMoveKeepCCSID branch October 23, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@worksofliam worksofliam worksofliam approved these changes

Assignees

@sebjulliand sebjulliand

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

File copy and paste of IFS files do not maintain original encoding

2 participants

@sebjulliand @worksofliam