Do not modify workbench.editor.enablePreview status on startup#2694
Merged
sebjulliand merged 1 commit intomasterfrom May 29, 2025
Merged
Do not modify workbench.editor.enablePreview status on startup#2694sebjulliand merged 1 commit intomasterfrom
workbench.editor.enablePreview status on startup#2694sebjulliand merged 1 commit intomasterfrom
Conversation
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Contributor
|
👋 A new build is available for this PR based on c07dd1b. |
|
@sebjulliand I've installed the downloaded extension from VSIX. The workbench.editor.enablePreview setting stays as is. I also opened a few members, did some compiles, and didn't recognize any unreasonable or random output. Seems to work for me, but maybe some heavy users should do more tests. |
Member
Author
|
Thanks a lot for your feedback @thomseno 🤝🏻 |
worksofliam
approved these changes
May 29, 2025
Member
worksofliam
left a comment
There was a problem hiding this comment.
@sebjulliand Much better this time around. Thanks!
Side note: it did expose some spamming of RPGLINT.MBR in the RPGLE language server. I need to look into that ASAP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #2062.
Revert the change made to fix this #928 (comment)
Assuming this was due to QSYS FS
stat()method not being fully implemented back then, it should be fine now it returns the actual member modification date.How to test this PR
Checklist
console.logs I added