Merged
Conversation
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Contributor
|
👋 A new build is available for this PR based on 864cea3. |
worksofliam
approved these changes
May 5, 2025
Member
worksofliam
left a comment
There was a problem hiding this comment.
Thanks, and the tests are passing - great!
A new test case for a member name with a . is welcome, but optional.
Member
Author
OK I'll add a test case but just because it's you. |
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Member
Author
|
There you go @worksofliam. I'll let you merge if you're happy with the test case. |
worksofliam
approved these changes
May 5, 2025
Member
worksofliam
left a comment
There was a problem hiding this comment.
@sebjulliand Merge whenever you're ready!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2647 .
Searching through a source file containing members with a
.in their name would prevent them from being opened from the Search Result view. The paths displayed in the search result view were also truncated.The member path parsing from grep results has been fixed and it works fine now.
How to test this PR
.in their nameChecklist