Enabled multi-selection support for several commands by sebjulliand · Pull Request #2620 · codefori/vscode-ibmi

sebjulliand · 2025-04-19T10:16:43Z

Changes

As discussed here: https://github.com/orgs/codefori/discussions/2612

This PR enables multi-selection support for the following commands:

Generate binder source
Browse/edit members
Browse/edit IFS files
Maintain filter
Custom actions
Search source file
Search in IFS
Find in IFS

Run multiple custom actions

Some noticeable changes were done to allow running custom actions on multiple items.

All the selected items must share the same nature (i.e. URI scheme) (otherwise a warning is shown)
If the command must be prompted ~~, it will do so for each item~~:
- If the action is run on a single item, it will be prompted as usual
- If the action is run on multiple items, it will be prompted once, keeping the variables placeholders
The whole execution can now be cancelled. It will stop the process after the current item is done being processed
The output webview had been enhanced to display multiple outputs. The left side displays items' path and the right side shows the selected item output. The icon in front of the item shows the execution result (ok, failed or not run).
Running an action on a single item will only show the single output (no need for navigating through multiple results)

Search in members / Search/find in streamfiles

Finding or searching can be cancelled. The search will stop after the current path is done being processed.
Once a path has been processed, the results are added to the Search Results view, which means the view gets populated dynamically while the search is running.

How to test this PR

Use ctrl+click or shift+click to select multiple items in the Object browser or IFS browser
Check that actions are consistently shown
The the actions mentioned in the description

Checklist

have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

github-actions · 2025-04-19T10:17:34Z

👋 A new build is available for this PR based on 0b16e33.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand · 2025-04-19T12:38:22Z

Edit: on second thought, prompted custom actions should be prompted once and executed many times instead of prompting each item.

worksofliam

Generally the code looks ok but I left some comments.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand · 2025-04-29T21:17:41Z

Thanks @worksofliam ; see my comment and give it a go 😀

worksofliam · 2025-05-01T12:29:00Z

@sebjulliand Generally it's looking good. I want to also add at least one test case for each file system in src/testing/action.ts which run an action against multiple files. What do you think?

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand · 2025-05-03T17:13:43Z

@worksofliam tests are in, one for each scheme as requested.
I'll let you have a final look. Thanks!

worksofliam

It's looking great. This is a serious UX improvement for everyone! Fab work here. Please see my comment for peace of mind. Merge when ready.

worksofliam · 2025-05-05T17:53:12Z

 export function registerActionsCommands(instance: Instance): Disposable[] {
  return [
-    commands.registerCommand(`code-for-ibmi.runAction`, async (target: TreeItem | BrowserItem | Uri, group?: any, action?: Action, method?: DeploymentMethod, workspaceFolder?: WorkspaceFolder) => {
+    commands.registerCommand(`code-for-ibmi.runAction`, async (item?: (TreeItem | BrowserItem | Uri), items?: (TreeItem | BrowserItem | Uri)[], action?: Action, method?: DeploymentMethod, workspaceFolder?: WorkspaceFolder) => {


Just to confirm: you changed group to items here, and I don't think this is a breaking change because group was never used, right?

Yep, it was put here as a placeholder, when Project Explorer started to call it I think. So that second argument was mandatory in case the command was called with multiple item selected (otherwise it would have shifted the other arguments).
Long story short: it was never used (it was grayed out in the editor), now it is. 🤘🏻

worksofliam

Whoops, pressing the Run Action button on the editor UI causes this error.

sebjulliand · 2025-05-05T18:11:57Z

Whoops, pressing the Run Action button on the editor UI causes this error.

Darn 😅 I'll see it fixed.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand · 2025-05-05T20:39:05Z

Whoops, pressing the Run Action button on the editor UI causes this error.

Fixed it! Turned out calling a command from the editor UI sends the command's group id as the second parameter, and not undefined or an array as when run from a tree view.

worksofliam

Working now! Thanks for the fix! Merge when you're ready.

chrjorgensen · 2025-05-15T13:19:48Z

@sebjulliand I've just used your excellent change for the first time (using the prerelease version), and I have an idea for improvement:

Can we show the path of the member or streamfile for which the action is being run? Currently it's a count, but it would be nice to know the file also - especially if something hangs or is slow.

WDYT? 🤔

sebjulliand · 2025-05-15T13:27:00Z

@sebjulliand I've just used your excellent change for the first time (using the prerelease version), and I have an idea for improvement:

Can we show the path of the member or streamfile for which the action is being run? Currently it's a count, but it would be nice to know the file also - especially if something hangs or is slow.

WDYT? 🤔

Thank you @chrjorgensen !
It sure is a good idea - do you want to take care of it? Else I can, no problem, I have the exact location under my eyes 😁

chrjorgensen · 2025-05-15T13:33:41Z

@sebjulliand Unfortunately I'm still very busy with work, so I don't have the time... 😭
but I would be grateful if you can fix this. 🙏

sebjulliand · 2025-05-15T13:45:54Z

@sebjulliand Unfortunately I'm still very busy with work, so I don't have the time... 😭 but I would be grateful if you can fix this. 🙏

You can count on me 🤝🏻

sebjulliand · 2025-05-16T08:02:51Z

There you go @chrjorgensen : #2674

sebjulliand added 13 commits April 12, 2025 18:09

Restrict multi-selection on commands

5e220c9

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Muli-selection support for generateBinderSource command

b19d5cf

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Muli-selection support for code-for-ibmi.browse/edit commands

357742e

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Enabled multi selection for openIFSFile menu

5a36e20

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Enabled multi selection for maintainFilter command

8fdaf08

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Fixed filter update when multiple filters are opened simultaneously

00a1903

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

multi selection actions (work in progress)

9930c58

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Multi selection actions working

111aa60

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Fixed names uppercasing

f6be325

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Enhanced actions result panel for multi executions

ab03174

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Enabled multi selection for search in source files

82511f8

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Enabled multi selection for search and find in streamfiles

2f05e1a

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Fixed warning

50d781e

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand added the enhancement New feature or request label Apr 19, 2025

sebjulliand requested a review from a team April 19, 2025 10:16

sebjulliand self-assigned this Apr 19, 2025

sebjulliand temporarily deployed to testing_environment April 19, 2025 10:16 — with GitHub Actions Inactive

Prompt once, execute many

37f4714

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand temporarily deployed to testing_environment April 19, 2025 12:34 — with GitHub Actions Inactive

worksofliam requested changes Apr 29, 2025

View reviewed changes

Comment thread src/webviews/filters/index.ts Outdated

Comment thread src/ui/actions.ts

Comment thread src/ui/actions.ts

sebjulliand added 3 commits April 29, 2025 23:08

Allow runAction on multiple IFS files

11c3eae

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Make sure every action target belong to the same workspace

76b10ce

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Cleaner config object access

e805a28

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand had a problem deploying to testing_environment April 29, 2025 21:15 — with GitHub Actions Failure

sebjulliand requested a review from worksofliam April 29, 2025 21:17

Added getLocalActionsFiles method

44eac22

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand added 2 commits May 2, 2025 17:08

Enabled actions to run on multiple local files

ada4d2c

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Merge branch 'master' into multiActionSupport

9c9a667

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand had a problem deploying to testing_environment May 2, 2025 15:30 — with GitHub Actions Failure

sebjulliand added 3 commits May 3, 2025 16:49

Duplicated warning to check actions uri scheme

798d625

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Fixed toPaseVariables exporting invalid pase variables

094a782

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Added tests for each action schemes to test multiple executions

38ff4af

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand had a problem deploying to testing_environment May 3, 2025 17:12 — with GitHub Actions Failure

worksofliam approved these changes May 5, 2025

View reviewed changes

worksofliam requested changes May 5, 2025

View reviewed changes

Fixed running action from editor UI

0b16e33

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand had a problem deploying to testing_environment May 5, 2025 20:36 — with GitHub Actions Failure

sebjulliand requested a review from worksofliam May 5, 2025 20:39

worksofliam approved these changes May 6, 2025

View reviewed changes

sebjulliand merged commit 564c128 into master May 6, 2025
4 of 5 checks passed

sebjulliand deleted the multiActionSupport branch May 6, 2025 06:45

Conversation

sebjulliand commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Run multiple custom actions

Search in members / Search/find in streamfiles

How to test this PR

Checklist

Uh oh!

github-actions bot commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebjulliand commented Apr 19, 2025

Uh oh!

worksofliam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebjulliand commented Apr 29, 2025

Uh oh!

worksofliam commented May 1, 2025

Uh oh!

sebjulliand commented May 3, 2025

Uh oh!

worksofliam left a comment

Choose a reason for hiding this comment

Uh oh!

worksofliam May 5, 2025

Choose a reason for hiding this comment

Uh oh!

sebjulliand May 5, 2025

Choose a reason for hiding this comment

Uh oh!

worksofliam left a comment

Choose a reason for hiding this comment

Uh oh!

sebjulliand commented May 5, 2025

Uh oh!

sebjulliand commented May 5, 2025

Uh oh!

worksofliam left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrjorgensen commented May 15, 2025

Uh oh!

sebjulliand commented May 15, 2025

Uh oh!

chrjorgensen commented May 15, 2025

Uh oh!

sebjulliand commented May 15, 2025

Uh oh!

sebjulliand commented May 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sebjulliand commented Apr 19, 2025 •

edited

Loading

github-actions bot commented Apr 19, 2025 •

edited

Loading

worksofliam left a comment •

edited

Loading