Skip to content

Set locale via LC_ALL when using cqsh or qsh#2546

Merged
worksofliam merged 2 commits intocodefori:masterfrom
SanjulaGanepola:fix/locales
Mar 4, 2025
Merged

Set locale via LC_ALL when using cqsh or qsh#2546
worksofliam merged 2 commits intocodefori:masterfrom
SanjulaGanepola:fix/locales

Conversation

@SanjulaGanepola
Copy link
Copy Markdown
Member

@SanjulaGanepola SanjulaGanepola commented Mar 3, 2025

Changes

Fixes #2531 by setting LC_ALL when using cqsh or qsh.

How to test this PR

Run the test suite or query for objects in the Object Browser that contain NL chars such as in #2531

Checklist

  • have tested my change

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola temporarily deployed to testing_environment March 3, 2025 21:07 — with GitHub Actions Inactive
@SanjulaGanepola SanjulaGanepola marked this pull request as draft March 3, 2025 21:10
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola changed the title Set locale via LC_ALL even when using cqsh Set locale via LC_ALL even when using cqsh or qsh Mar 3, 2025
@SanjulaGanepola SanjulaGanepola temporarily deployed to testing_environment March 3, 2025 22:32 — with GitHub Actions Inactive
@SanjulaGanepola SanjulaGanepola changed the title Set locale via LC_ALL even when using cqsh or qsh Set locale via LC_ALL when using cqsh or qsh Mar 3, 2025
@SanjulaGanepola SanjulaGanepola marked this pull request as ready for review March 3, 2025 22:33
@worksofliam
Copy link
Copy Markdown
Member

Looks like the tests are passing for me:

image

@worksofliam
Copy link
Copy Markdown
Member

There is a chance this bug will fix #2519, and this is where the bug was introduced: 84d21dd#diff-af91aaa8436f73c4457121b35da47e46d53459b47f044b7dbdb78ea785cb1824R1449

@worksofliam worksofliam merged commit 10698d3 into codefori:master Mar 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CCSID issue found in NLAURORABRATEST

2 participants