Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

manual trigger#14

Merged
dana-yaish merged 3 commits intomainfrom
dana/manual-trigger
Jul 24, 2023
Merged

manual trigger#14
dana-yaish merged 3 commits intomainfrom
dana/manual-trigger

Conversation

@dana-yaish
Copy link
Contributor

creating new task that waits for uploads to process, then triggers notifs, syncs pull and computes comparison

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@dana-yaish dana-yaish force-pushed the dana/manual-trigger branch from 228d094 to bbd268b Compare July 17, 2023 14:59
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #14 (d09c082) into main (07f5fd5) will decrease coverage by 0.02%.
The diff coverage is 95.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   98.61%   98.60%   -0.02%     
==========================================
  Files         327      329       +2     
  Lines       25192    25294     +102     
==========================================
+ Hits        24843    24940      +97     
- Misses        349      354       +5     
Flag Coverage Δ
integration 98.60% <95.09%> (-0.02%) ⬇️
latest-uploader-overall 98.60% <95.09%> (-0.02%) ⬇️
unit 98.60% <95.09%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.29% <93.84%> (-0.03%) ⬇️
OutsideTasks 98.36% <ø> (ø)
Impacted Files Coverage Δ
tasks/manual_trigger.py 93.75% <93.75%> (ø)
tasks/tests/unit/test_manual_trigger.py 97.29% <97.29%> (ø)
tasks/__init__.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment here, although I don't think it will be done now, for this task to go into the special queues config you need to add an entry for it here:

def _get_user_plan_from_task(dbsession, task_name: str, task_kwargs: dict) -> str:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate the Manual Trigger with Codecov CLI

2 participants