This repository was archived by the owner on May 21, 2025. It is now read-only.
failing on GitLab ≥ 9 (bis)#208
Closed
romain-dartigues wants to merge 2 commits intocodecov:masterfrom
romain-dartigues:gitlab-ci-variables
Closed
failing on GitLab ≥ 9 (bis)#208romain-dartigues wants to merge 2 commits intocodecov:masterfrom romain-dartigues:gitlab-ci-variables
romain-dartigues wants to merge 2 commits intocodecov:masterfrom
romain-dartigues:gitlab-ci-variables
Conversation
Compatibility with the deprecated variables listed in https://docs.gitlab.com/ee/ci/variables/deprecated_variables.html
1 similar comment
thomasrockhu
approved these changes
May 27, 2020
Contributor
thomasrockhu
left a comment
There was a problem hiding this comment.
Thanks for the commit here!
Contributor
|
Please update the conflicting files and I'll merge in |
Contributor
|
@thomasrockhu I have a fixed commit in my fork. Do you want a new PR? |
Contributor
|
that would be great @nmoinvaz . Please tag the new PR here and I'll merge it |
Contributor
|
Done #264. Thanks! |
Contributor
|
Closed as a result of #264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously listed in #96 and #97, GitLab 9.0 (released in March 2017) renamed some variables which are still used in
codecov.The following patch keep the compatibility with pre-9 releases (GitLab 8 was deprecated around August 2017).
https://about.gitlab.com/blog/categories/releases/